Problem/Motivation

SMS User message sleep and opt-out settings should not be visible when a number is not registered since those settings are meaningless and don't work without a number anyway

Proposed resolution

Make the Sleep and Opt out settings hidden if a number has not yet been registered.

Remaining tasks

Patch
Review
Commit

User interface changes

SMS User sleep and opt out settings will only be visible after a user has successfully registered a number.

API changes

None

CommentFileSizeAuthor
#3 sms_user_sleep_settings-2396903-3.patch2.59 KBalmaudoh
#1 sms_user_sleep_settings-2396903-1-fail.patch1.7 KBalmaudoh

Comments

almaudoh’s picture

almaudoh commented
Status: Active » Needs review
StatusFileSize
new sms_user_sleep_settings-2396903-1-fail.patch1.7 KB

Attached a patch with tests that should fail.

Status: Needs review » Needs work

The last submitted patch, 1: sms_user_sleep_settings-2396903-1-fail.patch, failed testing.

almaudoh’s picture

almaudoh commented
Status: Needs work » Needs review
StatusFileSize
new sms_user_sleep_settings-2396903-3.patch2.59 KB

Now the patch with the fix.

  • almaudoh committed f0f5d2b on 7.x-1.x 
    Issue #2396903 by almaudoh: SMS user sleep and opt-out settings should...
almaudoh’s picture

almaudoh commented
Status: Needs review » Fixed

Committed / pushed to 7.x-1.x

almaudoh’s picture

almaudoh commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Fixed » Patch (to be ported)

This fix needs to be ported to 8.x-1.x

  • almaudoh committed 3c662ea on 8.x-1.x 
    Issue #2396903 by almaudoh: SMS user sleep and opt-out settings should...
almaudoh’s picture

almaudoh commented
Status: Patch (to be ported) » Fixed

Ported to D8 (8.x-1.x-dev)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.