The page at admin/structure/comment/types/add has the title 'Add'. This should say 'Add comment type' to match admin/structure/types/add.

CommentFileSizeAuthor
#6 drupal.comment-type-add-page-title1.patch493 bytesprajaankit
#1 2396537.drupal.comment-type-add-page-title.patch493 bytesjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 2396537.drupal.comment-type-add-page-title.patch493 bytes

Status: Needs review » Needs work

The last submitted patch, 1: 2396537.drupal.comment-type-add-page-title.patch, failed testing.

joachim’s picture

joachim commented
Status: Needs work » Needs review

Weird. Applies fine for me.

joachim queued 1: 2396537.drupal.comment-type-add-page-title.patch for re-testing.

shackr’s picture

shackr commented

Yes, the Patch works for me.

prajaankit’s picture

prajaankit commented
Issue tags: +sprintweekendDelhi
StatusFileSize
new drupal.comment-type-add-page-title1.patch493 bytes

#7

yesct’s picture

yesct commented
Issue tags: -sprintweekendDelhi +SprintWeekend2015

Thanks for the patch.

Did the old one not apply anymore? What is the difference between the patch in #1 and #6?

We should all try and use the same sprint tag. According to https://groups.drupal.org/node/447258 it should be SprintWeekend2015 with no #.

msound’s picture

msound commented
Status: Needs review » Reviewed & tested by the community

Patch #1 works. There is no difference between #1 and #6, other than the filename.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch! This looks consistent with what node types do:

node.type_add:
  path: '/admin/structure/types/add'
  defaults:
    _entity_form: 'node_type.add'
    _title: 'Add content type'
  requirements:
    _permission: 'administer content types'

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 8f9c2bb on 8.0.x 
    Issue #2396537 by joachim, prajaankit, shackr, msound: page title for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.