I know that only PHP 5.3 is supported in D6 and therefore this patches are less likely, but since php 5.4 is getting more ubiquitous and I am using a lot on D6 sites, some of the notices and warnings can be easily fixed without much compromise.

CommentFileSizeAuthor
#1 ubercart-fix-php54-warnings-credit-payment-2396223-1.patch1.51 KBhanoii

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Active » Needs review
StatusFileSize
new ubercart-fix-php54-warnings-credit-payment-2396223-1.patch1.51 KB

Attached is a patch for two of them.

Status: Needs review » Needs work

The last submitted patch, 1: ubercart-fix-php54-warnings-credit-payment-2396223-1.patch, failed testing.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Version: 7.x-3.x-dev » 6.x-2.x-dev

Status: Needs work » Needs review

hanoii queued 1: ubercart-fix-php54-warnings-credit-payment-2396223-1.patch for re-testing.

  • TR committed f4c825f on 6.x-2.x authored by hanoii 
    Issue #2396223 by hanoii: Fixing php 5.4 static warnings on uc_credit...
tr’s picture

tr commented
Status: Needs review » Fixed

OK. Committed. Thanks.

7.x-3.x and 8.x-4.x don't have this issue.

Please note that 6.x-2.x is almost obsolete - please upgrade! We will be dropping even minimal support for 6.x-2.x as soon as Drupal 8 is out.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.