Would it be possible to display the user picture in the results if user pictures are enabled on the site?

CommentFileSizeAuthor
#9 linkit-display_user_picture-2395651-9.patch1.31 KBPascalAnimateur
#5 linkit-display_user_picture-2395651-5.patch1.84 KBPascalAnimateur
#2 linkit-display_user_picture-2395651-2.patch2.91 KBPascalAnimateur
#1 linkit-display_user_picture-2395651.patch1.18 KBPascalAnimateur
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

PascalAnimateur’s picture

PascalAnimateur CreditAttribution: PascalAnimateur commented
FileSize
linkit-display_user_picture-2395651.patch1.18 KB

Looks like it is possible !

PascalAnimateur’s picture

PascalAnimateur CreditAttribution: PascalAnimateur commented
FileSize
linkit-display_user_picture-2395651-2.patch2.91 KB

Even better patch with email display and translation of the entity label.

There should be corresponding options for (picture / email) in the user search plugin settings.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented

Yes, this could be a feature.

I have some comments about the patch tho.

- Why use t() on the description? The reason why its not there now is that the description is "user input". Check https://api.drupal.org/api/drupal/includes%21bootstrap.inc/function/t/7

- There should be a setting for this in the "User plugin settings" that is default off.

- The typo fix can still be in the patch, I don't mind that.

If you fix this, I'll gladly commit this.

Northern_Girl’s picture

Northern_Girl CreditAttribution: Northern_Girl commented

Hi.

Was this finally commited ? I'm a new user to Linkit and this is something that I would like to have.

Thanks.

PascalAnimateur’s picture

PascalAnimateur CreditAttribution: PascalAnimateur commented
FileSize
linkit-display_user_picture-2395651-5.patch1.84 KB

Here's a revised patch with only the user image display, no t() in the description.

PascalAnimateur’s picture

PascalAnimateur CreditAttribution: PascalAnimateur commented
Status: Active » Needs review
PascalAnimateur’s picture

PascalAnimateur CreditAttribution: PascalAnimateur commented

Patch also includes fix for issue #2550209: Image not appearing in autocomplete result

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Status: Needs review » Needs work

Well, it sure fixes the two issues, but it reintroduce a security issue.

We need to sanitize the output. That is done by Drupal.checkPlain(result.description) today. If we remote that, it open for XSS attacks.

PascalAnimateur’s picture

PascalAnimateur CreditAttribution: PascalAnimateur commented
Version: 7.x-3.x-dev » 7.x-3.5
Status: Needs work » Needs review
FileSize
linkit-display_user_picture-2395651-9.patch1.31 KB

Re-rolled patch against 7.x-3.5

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Status: Needs review » Needs work

I would like to see this configurable in the user plugin.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer and at University of Texas at Austin commented
Status: Needs work » Closed (won't fix)

In order to help the community and the module maintainers focus work on the issues for this module that are most important to the Drupal community, I'm going to close this issue, as it is a feature request that does not have substantial work already and the issue hasn't been updated in many years.