Do not remove 0 from config translation data

Awesome, thanks a lot!

I've hit this exact problem over in #2381147-4: Text and text with summary field default value config does not use the text_format schema type. See my 2. over in that comment.

1. +++ b/core/modules/config_translation/src/FormElement/ListElement.php
   @@ -134,4 +134,21 @@ protected function getGroupTitle(DataDefinitionInterface $definition, array $gro
   +   * Get compound element key.
   

   Docs formatting - should be Gets....

2. +++ b/core/modules/config_translation/src/FormElement/ListElement.php
   @@ -134,4 +134,21 @@ protected function getGroupTitle(DataDefinitionInterface $definition, array $gro
   +   * @param $base_key
   +   *   The base key.
   +   *
   +   * @param $key
   

   Unneeded blank(ish) line.

3. +++ b/core/modules/config_translation/src/FormElement/ListElement.php
   @@ -134,4 +134,21 @@ protected function getGroupTitle(DataDefinitionInterface $definition, array $gro
   +   * @return string
   +   */
   

   Need to doc what the return value is.

4. +++ b/core/modules/config_translation/src/FormElement/ListElement.php
   @@ -134,4 +134,21 @@ protected function getGroupTitle(DataDefinitionInterface $definition, array $gro
   +    return implode('.', array_filter(array($base_key, $key), function ($value) {
   +      return isset($value);
   +    }));
   

   An inline comment might be nice.

5. This issue is a normal bug so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary.

Just marked #2413481: Sequence translation as duplicate. That one simply uses an ltrim() instead of the array_filter(), which seems a little less (conceptual, not performance) overhead IMO. In any case, that means we should really fix this as multiple people (myself included) have been bitten by this.

Here we go.

Fixed #5 added a beta evaluation and a suggested commit message, because I brought the ltrim() over from the referenced issue.

Well, actually pasting the suggested commit message helps...

Hehe, 8.0.x changed a bit in the meantime, so the test code itself "failed"...

1. +++ b/core/modules/config_translation/src/FormElement/ListElement.php
   @@ -55,7 +55,7 @@ public function getTranslationBuild(LanguageInterface $source_language, Language
          // Make the specific element key, "$base_key.$key".
   

   This comment may not be accurate anymore. Probably not needed as its a method now.

2. +++ b/core/modules/config_translation/src/FormElement/ListElement.php
   @@ -134,4 +134,20 @@ protected function getGroupTitle(DataDefinitionInterface $definition, array $gro
   +   *   The base key or NULL of this is the top-level element.
   

   of => if

   In general it would be great to explain what are base and subkeys now that this is removed from its original surroundings.

3. +++ b/core/modules/config_translation/src/Tests/ConfigTranslationUiTest.php
   @@ -702,6 +702,43 @@ public function testAlterInfo() {
   +  public function testSequenceTranslation() {
   

   Add comment block on method.

Not being actively worked on.

as @tstoeckler suggested here #2413481: Sequence translation there is a similar approach that would fix that as well, maybe we want to merge these two

@Schnitzel: wanna work on this? :)

@Schnitzel: I the latest patch already "merges" the two approaches in that I brought over the ltrim().

@Gabor
Wanna have it fixed yes :D
And yep, will check that I or one of my people will spend some time on it.

2395627-20.patch includes all fixes for #14

2395627-20-v2.patch is just another approach. It doesn't add the getElementKey() method, reasons:
- the $base_key variable is already described in getTranslationBuild() and setConfig() methods; there is no need to describe it in another one place
- when I see $element_key = isset($base_key) ? "$base_key.$key" : $key; I don't need any comments to understand what's happennig

Yeah v2 makes more sense, we don't need a method introduced to concatenate strings. Uploading again to make sure this one will be committed and not the other one.

Committed 1ff477b and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

Yay, thanks all!