Text and text with summary field default value config does not use the text_format schema type

Changes config schema, so D8 upgrade path tag should be on.

Ok this does not actually change the config data structure like #2144505: Views does not use the text format type for formatted text, so this does not need the D8 upgrade path tag. I assumed it will change the data structure, but looks like it does not.

#2348459: Fields of type 'Text (formatted)' do NOT save values. landed. Should be possible to write tests for this now?

#2144505: Views does not use the text format type for formatted text also landed. Yay!

@tstoeckler: still working in this one or should we look for someone else to finish?

Unfortunately not being actively worked on so removing from sprint.

I can confirm this issue still exists.

Reroll added for patch #18.

patch failed

Okay I found the issue. The patch in #28 removed changes from #18 and I didn't notice that in my attempt at #30.

For the committer please update credit to match.

Rerolled #18 correctly.

Attempted to create an interdiff but got
1 out of 2 hunks FAILED -- saving rejects to file /var/folders/z8/ym9ls3bj01x19hd8xfvsyk_40000gn/T//interdiff-1.FQffex.rej
interdiff: Error applying patch1 to reconstructed file

Hi I've tested this patch #34 on drupal 10.1.x and it works.

First, posting the raw interdiff content of 0 bytes interdiff-32-33.txt

$ diff 2381147-32.patch 2381147-33.patch
83c83
< index 42d54b21ef..d1d7bad78f 100644
---
> index f60c0a56ee..fc053f29f8 100644
94c94
< @@ -1108,6 +1109,70 @@ public function testMenuTranslationWithoutChange() {
---
> @@ -1111,6 +1112,70 @@ public function testMenuTranslationWithoutChange() {
191c191
< index 08bc9aad87..5a9f3ac4f4 100644
---
> index e0fa5d3d83..ae2ab6ee2f 100644
194,195c194,195
< @@ -21,15 +21,8 @@ field.field_settings.text:
<    label: 'Text (formatted) settings'
---
> @@ -27,15 +27,8 @@ field.field_settings.text:
>          type: string
211,212c211,212
< @@ -40,15 +33,8 @@ field.field_settings.text_long:
<    type: mapping
---
> @@ -52,15 +45,8 @@ field.field_settings.text_long:
>          type: string
228,229c228,229
< @@ -66,18 +52,8 @@ field.field_settings.text_with_summary:
<        label: 'Require summary'
---
> @@ -83,18 +69,8 @@ field.field_settings.text_with_summary:
>          type: string

2. review the schema changes

Posting the schema of text_format from core/config/schema/core.data_types.schema.yml

# Text with a text format.
text_format:
  type: mapping
  label: 'Text with text format'
  # We declare the entire mapping of text and text format as translatable. This
  # causes the entire mapping to be saved to the language overrides of the
  # configuration. Storing only the (to be formatted) text could result in
  # security problems in case the text format of the source text is changed.
  translatable: true
  mapping:
    value:
      type: text
      label: 'Text'
      # Mark the actual text as translatable (in addition to the entire mapping
      # being marked as translatable) so that shipped configuration with
      # formatted text can participate in the string translation system.
      translatable: true
    format:
      type: string
      label: 'Text format'
      # The text format should not be translated as part of the string
      # translation system, so this is not marked as translatable.

+++ b/core/modules/text/config/schema/text.data_types.schema.yml
@@ -0,0 +1,19 @@
+# See the 'text_format' type in core.data_types.schema.yml.
+text_format_with_summary:
+  label: 'Default'
+  type: mapping
+  translatable: true
+  # Integrate with the Configuration Translation module.
+  form_element_class: 'Drupal\text\FormElement\TextFormatWithSummary'
...
+    value:
+      type: text
+      label: 'Body'
+      translatable: true
+    summary:
+      type: string
+      label: 'Summary'
+      translatable: true
+    format:
+      type: string
+      label: 'Text format'

• With the form_element_class key which is good, see hook_config_schema_info_alter below
• format is not translatable as text_format

function hook_config_schema_info_alter(&$definitions) {
  // Enhance the text and date type definitions with classes to generate proper
  // form elements in ConfigTranslationFormBase. Other translatable types will
  // appear as a one line textfield.
  $definitions['text']['form_element_class'] = '\Drupal\config_translation\FormElement\Textarea';
  $definitions['date_format']['form_element_class'] = '\Drupal\config_translation\FormElement\DateFormat';
}

+++ b/core/modules/config_translation/src/FormElement/TextFormat.php
@@ -27,14 +28,15 @@ public function getSourceElement(LanguageInterface $source_language, $source_con
-    return [
+    return NestedArray::mergeDeep(parent::getTranslationElement($translation_language, $source_config, $translation_config), [
...
-    ] + parent::getTranslationElement($translation_language, $source_config, $translation_config);

Should we respect the order here? I'm not sure if it's relevant in this case, but could hide bugs.
PHP arrays addition is not commutative (A+B != B+A).

I don't see why those css classes are needed now and not before, but being fair I didn't really test it.

+++ b/core/modules/text/config/schema/text.schema.yml
@@ -27,15 +27,8 @@ field.field_settings.text:
 field.value.text:
-  type: mapping
+  type: text_format
   label: 'Default value'
-  mapping:
-    value:
-      type: label
-      label: 'Value'
-    format:
-      type: string
-      label: 'Text format'

This is great!

+++ b/core/modules/config_translation/tests/src/Functional/ConfigTranslationUiTest.php
@@ -1111,6 +1112,70 @@ public function testMenuTranslationWithoutChange() {
+   * Test translation of a default value of a text with summary field.

As it's being set back to NW, here should start with 'Tests', #3133162: Replace the start verb Test with Tests in method comments of tests

I've been trying to test it manually, but I can not get the same result as the test. Leaving this issue temporarily

1. +++ b/core/modules/text/config/schema/text.data_types.schema.yml
   @@ -0,0 +1,19 @@
   +# See the 'text_format' type in core.data_types.schema.yml.
   

   While we're making this consistent, we should move the text_format type out of core.data_types.schema.yml and into this file.

2. +++ b/core/modules/text/src/FormElement/TextFormatWithSummary.php
   @@ -0,0 +1,41 @@
   +use Drupal\config_translation\FormElement\TextFormat;
   

   Let's move this class into the text module too while we're at it?

Sorry for taking so long to get back to this.

#39

Should we respect the order here? I'm not sure if it's relevant in this case, but could hide bugs.

that I'm not 100% about, may need a bigger brain then my own

Edit: As far as the classes go I believe they were copied from StringTextareWidget.php

#40 fixed

#41.1 moved
#41.2 moved

Moved to MR so hiding patches

Reverted #41.1 as it caused some failures and may want to handle in a follow up.

I agree we don't need to do #41.1 in this issue, it can be a followup for later. Can we file that already as a seperate issue? Otherwise this looks good to go imho.

Tagging so we don't forget #41.

Created #3395923: Move TextFormat form element from config_translation to text module
Created #3395927: Move text_format data type from core to text module

I think they are independent of each other. Removing "needs followup" tag.

Reverted the move.

We have split the bits that require BC layer into follow-ups. The fix itself was RTBC before, and I think it is, so setting it back to RTBC.

I'm triaging RTBC issues. I read the IS and the comments. I didn't find any unanswered questions or other work to do.

The diff does not apply to 11.x, there setting to NW for a rebase.

This may need a CR with a screenshot informing the user of this new capability.

Rebased done, hence moving to NR.
Still need a update on CR as requested in #52.

Thanks!

Restoring status after reroll.

Always nice to see an old issue getting attention, thanks!

Comment #53 states that this is in need of a CR, therefor setting back to needs work.

To learn more about what this is fixing I tested on Drupal 11.x today, standard install, with a second language and a Textwithsummary field. I was able to translate the default value field without the patch here. Yet, the issue summary states that this change is to allow, "Default values of text fields can be translated using a text editor." Am I missing something? I don't work with translations so maybe I am.

I applied that patch and the translation modal was changed so that both the english default value and the translation default value can be edited. I don't think that it correct, only the translation should be editable. In fact the title is "Edit Italian translation for TextWithSummary" so it should only be for the Italian version.

It is not clear to me what is being fixed here. Tagging for an issue summary update. And since this is changing the UI it should have links to up to date before/after screenshots in the issue summary.

Looking back at the comments I do not see any manual testing. I am adding a tag for that.