BrSniff checks for XHTML style br tags when HTML5 may be the doctype in use. With the increase in use of HTML5 and Drupal documentation listing both doctypes, does it still make sense to be enforcing XHTML style br tags?

CommentFileSizeAuthor
#8 coder-2395605-8.patch3.3 KBmarkdorison
#1 coder-2395605-1.patch853 bytesmarkdorison

Comments

markdorison’s picture

markdorison
he/him
commented
StatusFileSize
new coder-2395605-1.patch853 bytes

I have created a patch that disables this check.

markdorison’s picture

markdorison
he/him
commented
Status: Active » Needs review
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Version: 7.x-2.x-dev » 8.x-2.x-dev
Status: Needs review » Needs work

I agree, we can remove this sniff. Instead of disabling it in ruleset.xml you should remove the sniff class and check if the phpunit tests still pass (maybe we have to fix some test cases somewhere).

And this should be done in 8.x-2.x first.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Fixed

Removed the BrSniff. Thanks for reporting!

  • klausi committed 9f73e33 on 8.x-2.x 
    Issue #2395605 : Removed sniff for <br> tags since they are allowed in...
markdorison’s picture

markdorison
he/him
commented
Version: 8.x-2.x-dev » 7.x-2.x-dev
Status: Fixed » Patch (to be ported)

Thanks @klausi! Should this now be back ported to 7.x-2.x?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Yep, this can be backported to 7.x-2.x. Feel free to post a patch!

markdorison’s picture

markdorison
he/him
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new coder-2395605-8.patch3.3 KB

Backport to 7.x-2.x attached.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Fixed

Committed, thanks!

  • klausi committed 90da871 on 7.x-2.x authored by markdorison 
    Issue #2395605 by markdorison: Removed BrSniff for XHTML when HTML5 may...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.