Create a Drupal 8 version of the Legal module.
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | 2394783.patch | 1.54 KB | lomasr |
| #23 | 2394783-23.patch | 159.42 KB | edurenye |
| #14 | registration-and-ux-cleanup-fix.-2394783-13.patch | 82.61 KB | Anonymous (not verified) |
| #12 | legal-d8-2394783-12.patch | 134.48 KB | marvin_b8 |
Comments
Comment #1
robert castelo commentedComment #2
mikael berger commentedI get the following error when trying to install: legal-8.x-1.x-dev.tar.gz does not contain any .info.yml files. (The same goes for zip file).
Comment #3
Mircea Shanti commentedThe same. Any solutions?
Comment #4
Daniel Schaefer commentedI'm getting the following warning when installing via Drush:
array_flip(): Can only flip STRING and INTEGER values! EntityStorageBase.php:232.
The module enables but there is no configuration at all.
--
Edit. I am now getting this with every drush command so it may not be related to Legal. will keep you posted.
--
I tried uninstalling via the UI and it would return a "website encountered problem" WSOD. Uninstalling via drush returns
Comment #5
hazaI had a very quick look on the current 8.x branch. The code is really not ready now. My guess is that the d8 release should not even be displayed on the projet page since it obvisously can't work as it's current state.
Comment #6
robert castelo commentedDrupal 8 version of Legal module is currently only a branch for developers to work on, there is no official release yet.
Comment #7
hazaAgreed, but you could hide the "8.x-1.x-dev" release on the project page. It could prevent user to (easily) download the .tar.gz package and try to install it. Developper can still clone the git repository.
Comment #8
robert castelo commentedGood point, I've unticked 'Supported' so that it doesn't display on the project page.
Course now I'm going to get lots of issues with people asking if I'm working on a Drupal 8 version yet ;-)
Comment #9
Daniel Schaefer commentedI'm glad you've decided to pull back the version. Making sure we don't leave those standing in the rain who have already installed this module, we should address the experienced issues asap.
Comment #10
ikit-claw commentedAnything I can do to help this project? How can I get my hands on the dev version?
Comment #11
marvin_b8 commentedi work on a drupal 8 port at the momment
https://github.com/mbutkereit/legal
i will post tomorrow a patch for the current legal 8.x version.
Comment #12
marvin_b8 commentedA first alpha state patch for the d8 version.
I think everything work's like in d7 but there a lot of legacy code.
It's a patch for the current legal 8.x-1.x version.
Any feedback would be great.
(The same code is on github.)
Comment #13
Anonymous (not verified) commentedI gave it a try and after making a small change I got it working.
The account you want to verify could also be null in legal_form_user_form_alter.
I just changed this
and then it worked. Anyway a good starting point. Thx
Comment #14
Anonymous (not verified) commentedBased on your patch #12 I added some extensions and fixes like:
I found some other problems but I didn'T fix them yet. For example page link is not rendered correctly.
Comment #15
rfayJust a note that @marvin_B8's github repo has come along quite a way since the last post, and the version there is pretty usable, if imperfect. It would be great to bring it into the 8.x-1.x branch, just do it via git or whatever. https://github.com/mbutkereit/legal
Comment #16
caxy4 commentedI second @rfay's suggestion.
I'm using the latest from https://github.com/mbutkereit/legal on a production site and haven't encountered any issues.
I'd say the code is at least ready for an alpha.
Comment #17
Christopher Riley commentedCan we get an update as to the status of the module. Drupal 8 has been out for over a year and I have a site that I am trying to get up and running on D8 and really want to use this module.
Thanks in advance
Comment #18
hypertext200The Github version of the module is working fine, so please push it to the d.o git and create a release. Thanks @marvin_B8 for the great effort.
Thanks
Comment #19
smazBased on the above comments of the D8 version being used by several people for quite a while now, is it possible to bring the github repo as a release on d.org, even if alpha/beta for now?
Comment #20
smazComment #21
robert castelo commentedYes, but we'll need to wait until the security release for D7 version and then apply it to the beta.
Comment #22
edurenye commentedThe security release was already done few month ago, the github repo works fine enough, just import it so we can use it easily with drupal composer and we can continue improving it.
Comment #23
edurenye commentedThis is just the difference between drupal.org 8.x-1.x and github mbutkereit/legal 8.x-1.x. It's between if you pull commits from github to give credit to the correct people, I'm just uploading the patch to be able to use with composer patches.
Comment #24
lomasr commentedDrupal 8 git repo code does not look as per Drupal 8 coding standard for ex hook_help in Drupal 8 is now
Adding a patch for example.
Comment #25
lomasr commentedComment #27
robert castelo commentedCommited as part of today's London Drupal Sprint.
Special thanks to marvin_B8.
Comment #28
robert castelo commented