Problem/Motivation

When running the d6_file migration it doesn't correctly skip files that have been deleted. They're still stored in the files table until you run cron.

Proposed resolution

Update the EntityFile destination to use the status property and determine how to handle temporary files vs permanent files.

Remaining tasks

Write patch and tests.

User interface changes

API changes

CommentFileSizeAuthor
#8 2394157-8.patch8.03 KBbenjy
#7 interdiff.txt1.93 KBbenjy
#7 2394157-7.patch163.93 KBbenjy
#5 2394157-5.patch6.1 KBbenjy
#1 2394157-1-PASS.patch1.8 KBbenjy
#1 2394157-1-FAIL.patch1.8 KBbenjy

Comments

benjy’s picture

benjy commented
Status: Active » Needs review
StatusFileSize
new 2394157-1-FAIL.patch1.8 KB
new 2394157-1-PASS.patch1.8 KB

Pass and a fail patch attached.

The last submitted patch, 1: 2394157-1-FAIL.patch, failed testing.

chx’s picture

chx commented
Status: Needs review » Needs work

I am sorry but this is not a good idea. In theory it would be , in practice this leaves behind temporary files. There might be sites that use temporary files for whatever wacky purposes despite this is not officially sanctioned. I don't dare to risk it. We need to migrate all.

benjy’s picture

benjy commented
Title: d6_file errors out with temporary files » Update the EntityFile destination to handle temporary files
Issue summary: View changes
benjy’s picture

benjy commented
Status: Needs work » Needs review
StatusFileSize
new 2394157-5.patch6.1 KB

How about this approach, i've made some changes in the file process plugin and the EntityFile destination to handle temporary files.

Status: Needs review » Needs work

The last submitted patch, 5: 2394157-5.patch, failed testing.

benjy’s picture

benjy commented
Status: Needs work » Needs review
StatusFileSize
new 2394157-7.patch163.93 KB
new interdiff.txt1.93 KB

Needed to update the user picture file migration as well.

benjy’s picture

benjy commented
StatusFileSize
new 2394157-8.patch8.03 KB

Forgot to rebase before.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Looks really great.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Migration changes are not frozen in beta. Committed f14ec03 and pushed to 8.0.x. Thanks!

  • alexpott committed f14ec03 on 8.0.x 
    Issue #2394157 by benjy: Update the EntityFile destination to handle...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.