Latest release: https://github.com/jashkenas/underscore/releases/tag/1.7.0
Beta phase evaluation
| Issue priority | Not critical because it is just a minor upgrade. |
|---|---|
| Prioritized changes | The main goal of this issue is external PHP and asset library updates. |
| Disruption | Not disruptive |
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | interdiff-10-13.txt | 889 bytes | hussainweb |
| #13 | update_underscore_and-2393125-13.patch | 141.77 KB | hussainweb |
| #10 | update_underscore_and-2393125-10.patch | 141.76 KB | hussainweb |
Comments
Comment #1
mitrpaka commentedComment #2
nod_Can you add the minified version of the file please? We're getting that done while updating libs.
It means there needs to bee a { minified: true } option in the libraries entry, see the ckeditor entry for an example.
Apart from that: CKEditor, contextual, quickedit, toolbar and tour seems to be working still seems the couple of new versions didn't break our stuff. Might want to get Wim and/or Jesse to confirm as they ran into underscore (or backbone) version troubles way back.
Comment #3
nod_Actually we might want to update underscore and backbone in the same patch.
Comment #4
mitrpaka commentedLatest stable release for underscore.js is 1.7.0. #2233923: Update Backbone & Underscore included underscore.js version 1.6.0.
In 8.0.x-dev underscore.js was not minified and thus following the same pattern. But let's wait Wim and/or Jesse take on this.
Comment #5
mitrpaka commentedComment #6
nod_We're getting closer to alpha and it's time to ship minified libs, we don't do much debugging anymore #1341792-57: [meta] Ship minified versions of external JavaScript libraries. Also I wanted backbone and underscore updated at the same time because the backbone update looks really harmless and it's the main lib that depend on underscore.
Frontend testing is always a PITA, so testing 2 related libs in 1 issue is faster than testing each 1 time in separate issues.
Comment #7
nod_Porting tag from #2392917: Update JS lib: backbone to 1.1.2.
Comment #8
tarekdj commentedAttached patch updates :
backbone from 1.1.0 to 1.1.2 (minfied)
Underscore from 1.5.2 to 1.7.0 (minfied)
Everything seems to work fine except this error:
Which is related to Issue #2235299: Aggregation breaks use of library min.map files from included libraries
Comment #10
hussainwebI am just fixing the test here.
Comment #12
tarekdj commentedThis must be backbone-min.js
Comment #13
hussainwebAh, you're right. Attaching patch.
Comment #14
nod_Great, thanks.
Toolbar, quickedit, tabledrag, views ui still work.
Please credit droplet as well for his work on the backbone update issue referenced:
git commit -m 'Issue #2393125 by hussainweb, droplet, mitrpaka, tarekdj: Update underscore and backbone library to latest release'Comment #15
catchCommitted/pushed to 8.0.x, thanks!
Comment #17
bleen commentedTo be clear, should this commit resolve the
GET http://localhost/d8/sites/default/files/js/backbone-min.map; 404 (Not Found)message mentioned in #8? I ask because I just did a fresh install with HEAD and I still see that message (on node/add/article ... havent checked anywhere else).Comment #18
droplet commentedSource map won't affect general users. You could switch off Source Map supports in Chrome & Firefox's..etc.
(Or may be a follow up issue to remove them all from Core.)
Comment #20
alexpottI've opened #2424095: Add missing *.min.map so automatic prettification of compressed JS works in firefox and chrome to fix the *.min.map 404's