Clean-up field module test members - ensure property definition and use of camelCase naming convention

1. +++ b/core/modules/field/src/Tests/DisplayApiTest.php
   @@ -17,13 +17,6 @@
      /**
   -   * The field name to use in this test.
   -   *
   -   * @var string
   -   */
   -  protected $field_name;
   -
   -  /**
   

   Removed here.

2. +++ b/core/modules/field/src/Tests/DisplayApiTest.php
   @@ -98,12 +91,12 @@ protected function setUp() {
   -      ->setComponent($this->field_name, $this->display_options['default'])
   +      ->setComponent($this->field_name, $this->displayOptions['default'])
   

   Hence, not changed in this place.

3. +++ b/core/modules/field/src/Tests/ShapeItemTest.php
   @@ -29,20 +29,20 @@ class ShapeItemTest extends FieldUnitTestBase {
   -  protected $field_name = 'field_shape';
   +  protected $fieldName = 'field_shape';
   

   Not removed from here, but renamed.

4. +++ b/core/modules/field/src/Tests/ShapeItemTest.php
   @@ -29,20 +29,20 @@ class ShapeItemTest extends FieldUnitTestBase {
   -      'field_name' => $this->field_name,
   +      'field_name' => $this->fieldName,
   

   Converted to camel case due to change.

Why the difference, (1-2) and (3-4).

I did egrep -rl '\$this\->[a-z]+_[a-z_]+' core/modules/field/src/Tests/ and got the output:

core/modules/field/src/Tests/Boolean/BooleanFieldTest.php
core/modules/field/src/Tests/Email/EmailFieldTest.php
core/modules/field/src/Tests/FormTest.php
core/modules/field/src/Tests/reEnableModuleFieldTest.php
core/modules/field/src/Tests/FieldImportDeleteUninstallUiTest.php

There were only $this->web_user. I was looking into NumberFieldTest.php and there was this:

  /**
   * A user with permission to view and manage entities and content types.
   *
   * @var \Drupal\user\UserInterface
   */
  protected $webUser;

  protected function setUp() {
    parent::setUp();

    $this->webUser = $this->drupalCreateUser(array('view test entity', 'administer entity_test content', 'administer content types', 'administer node fields', 'administer node display', 'bypass node access'));
    $this->drupalLogin($this->webUser);
  }

Therefore, I made this changes to others too. I think these changes will make sense.
Also I see there are some commented-out codes in FormTest.php. Do you think we should remove it?

@Mile23 +1
So shall we change it everywhere else I mean also change it in NumberFieldTest.php. I have checked there, it uses $webUser just for login purpose, making it a class property does not make sense.

As for the commented codes, I will check whether they can be marked as TODO.

Just rerolling for now.

Back to NW as per #12.

Rerolling again... :)

Fixing the test. I think the other failure was random, something to do with a TWIG class not found.

Refactor unused properties:

• protected $webUser; from BooleanFieldtest.php. Follow #12
• protected $webUser; from NumberFieldTest.php. Follow #12
• protected $webUser; from EmailFieldTest.php. Follow #12
• protected $articleCreator; from reEnableModuleFieldTest.php. Follow #12

+++ b/core/modules/field/src/Tests/FieldImportDeleteUninstallUiTest.php
@@ -25,11 +25,18 @@ class FieldImportDeleteUninstallUiTest extends FieldTestBase {
+  /**
+   * A user with permission to synchronize configuration.
+   *
+   * @var \Drupal\user\UserInterface
+   */
+  protected $webUser;

Does not need to be a property.

The patch no longer applies and needs a reroll.
Doing it now.

Let's see what the testbot says. After it clears, I will make the changes suggested in #26.

Not sure why the test is failing.

Re-rolled!

Re-rolled and fixed broken test.

@rteijeiro: Might I suggest to include an interdiff for your fixes. I know you rerolled and an interdiff doesn't make sense there but in such situations, I post two different patches. The first just after rerolling and no changes, and second patch after the fixes where you can get an interdiff.

Fixing the exceptions.

I think the change requested in #26 got left out in middle of all the rerolls and failures. Doing that here.

Looks great! Good job @hussainweb! Thanks!

1. +++ b/core/modules/field/src/Tests/BulkDeleteTest.php
   @@ -50,7 +50,7 @@ class BulkDeleteTest extends FieldUnitTestBase {
       * @var array
       */
   -  protected $entity_type = 'entity_test';
   +  protected $entityType = 'entity_test';
   

   Let's rename this to $entityTypeId. Also it's not an array.

2. +++ b/core/modules/field/src/Tests/TranslationWebTest.php
   @@ -31,14 +31,14 @@ class TranslationWebTest extends FieldTestBase {
   -  protected $entity_type = 'entity_test_mulrev';
   +  protected $entityType = 'entity_test_mulrev';
   

   As above $entityTypeId

Nice catch, @alexpott! Thanks!

Yay! @alexpott: Should be good for RTBC again?

Back to RTBC?

Test code is not frozen in beta. Committed 1f37397 and pushed to 8.0.x. Thanks!