Filter: Allow plus sign in email addresses

Looks like a good fix to me - plus signs are valid in email addresses and without this patch it only picks up the parts after the plus sign as being a linkable email address, which is just broken.

Needs to go into Drupal 8 first though.

Let's add a test for this in FilterUnitTest.

Adding novice tag, adding a test for this should be very approachable for someone new to contributing, as should the review of the patch.

Hope this works.

Looks good. Here are screenshots post-patch:

At Install

User edit

FilterUnitTest

This looks good to me as well. I added a beta evaluation.

Committed d47bd72 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

I've added a small patch for D7, but need a sanity check. I tried D7.38 at simplytest.me and 7.x branch locally. Both allowed me to create accounts with emails containing plus signs without the patch. Does this match up with what others see when they try to add a user with an email containing a plus sign?

One way to be sure is to add tests.

The patch looks good, but yes, the Drupal 8 tests need to be backported also.

As far as I understand, this was only ever a bug with the text filtering, not with other places in core that use email addresses. (If it were other places too, like account creation, it would definitely be a more serious bug!)

Backported test also.

Working on the review at the mentored sprint in Barcelona with Gregg Marshall.

Reviewed the backport to D7 on 7.39, works like a charm.

Before:

After:

Barcelona Sprints: We're now done with this issue :)

double checked while mentoring

Committed to 7.x - thanks!