panels_mini_load & friends need caching

+++ b/panels_mini/panels_mini.module
@@ -145,6 +145,20 @@ function panels_mini_block_list_alter(&$blocks) {
+
+  $count = 0;
+  foreach ($blocks as $key => $block) {
+    if ($block->module != 'panels_mini') {
+      // This block was added by a contrib module, leave it in the list.
+      continue;
+    }
+    $count++;
+  }
+  if ($count > 15) {
+    // Load add at once to save time.
+    panels_mini_load_all();
+  }
+

Not sure the exact benefit of this? I get that it loads all of the mini panels at once instead of individual calls.

However, why after 15? Why not just invoke panels_mini_load_all() before the foreach(). If it returns empty, we can just skip the foreach through the block list all together, then.

Do you have any benchmarks? Such as using Panels, Why so slow?. Or a way to reproduce? I've been testing and all of our mini panels have been rendering in 0.15ms or so.

mikeytown2, thanks for reply! If you don't mind me asking, what are in the mini panels? Often times its the content, not the mini panel.

I think the first half could be useful - on blocks page just do one load to populate static cache at once.

I think there might more at hand. You can send me an email via contact form if you want if its all sensitive.

Any further progress on this? I wonder if there are many sites that use a lot of mini panels, e.g. 100 or more?

I noticed the following code:

      $output = cache_get_multiple($cids);
      foreach ($output as $mini) {
        if (!empty($mini->data)) {
          $mini = $mini->data;
          $cache[$mini->name] = $mini;
        }
      }
      if (empty($cids)) {
        return array_filter($cache);
      }

Does this not assume that $output is not empty? What's the rationale for checking if the $cids were empty before returning $cache?

Basically, could someone please provide comments to explain the logic? Thanks :)

PS, this patch removes the 15 block counter.

We're currently having to flush all the caches when we edit a panel; sorta getting old.

Is there one spot to clear the cache when it's edited?

Setting to needs work due to that comment. But thanks for the patch! Noticed I only have one mini panel but it's loading all over the place, even when there are no mini panels on the page!

FYI saved around 60ms on panels_mini_load! Beauty

Been using this patch for some time. Huge fan:)

We have been using the patch from #11 for awhile now without issue.

Patch works and I don't see any regressions (functional or performance) while testing. Will sorta have to take Joel's word for it that works better than without the patch. Although, Joel's word is pretty good ;)

Committed.

Well.. never trust Joel again! ;)

LOL, I only get one?

@samspinoy could you post that in a new issue? This one was closed and only maintainers can re-open and generally a new issue is better then multiple commits on the same issue.