Problem/Motivation

[#2391025]google_analytics_inline_js.patch

Fatal error: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 24 bytes) in drupal8\core\vendor\symfony\debug\Symfony\Component\Debug\Exception\FlattenException.php on line 217

Proposed resolution

Remaining tasks

Get inline JS back into core or this module is no longer working.

User interface changes

API changes

Original report by @username

CommentFileSizeAuthor
#12 Issue-2391029-by-hass-Attaching-inline-JS-no-longer-.patch1.7 KBhass
#11 Issue-2391029-by-hass-Attaching-inline-JS-no-longer-.patch1.71 KBhass
#9 google_analytics-attaching-inline-js-no-longer-possible-2391029-9.patch3.9 KBchipk
#7 google_analytics_inline_js-2391029-7-interdiff.txt504 bytesBerdir
#7 google_analytics_inline_js-2391029-7.patch3.85 KBBerdir
#5 google_analytics_inline_js.patch3.63 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass’s picture

hass CreditAttribution: hass commented
Issue summary: View changes
hass’s picture

hass CreditAttribution: hass commented
Parent issue: » #2391025: Add support for inline JS/CSS with #attached
hass’s picture

hass CreditAttribution: hass commented
Title: Attaching inline JS is broken » Attaching inline JS no longer possible. Help get this back into core!
hass’s picture

hass CreditAttribution: hass commented
Issue summary: View changes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Active » Needs review
FileSize
google_analytics_inline_js.patch3.63 KB
hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Needs work

Inline support is required in core. This does not solve the bug.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
google_analytics_inline_js-2391029-7.patch3.85 KB
google_analytics_inline_js-2391029-7-interdiff.txt504 bytes

Maybe, maybe not, but this does seem to work for me. Did notice one problem, and that was that the drupalSettings were not correct yet.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Postponed

I commit the DrupalSettings fix later, but the rest will not commited.

chipk’s picture

chipk CreditAttribution: chipk commented
FileSize
google_analytics-attaching-inline-js-no-longer-possible-2391029-9.patch3.9 KB

Tested google_analytics_inline_js-2391029-7.patch against 8.x-2.x (commit 42ed87a7d04a331e4f) and the patch failed to apply. Re-rolled patch and tested as now working.

noslokire’s picture

noslokire CreditAttribution: noslokire commented

Extremely unpleasant intro in D8, #9 got me pass the error screen at least.

hass’s picture

hass CreditAttribution: hass commented
FileSize
Issue-2391029-by-hass-Attaching-inline-JS-no-longer-.patch1.71 KB

Unstable workaround for the core bug.

hass’s picture

hass CreditAttribution: hass commented
FileSize
Issue-2391029-by-hass-Attaching-inline-JS-no-longer-.patch1.7 KB

  • hass committed e4475af on 8.x-2.x 
    Issue #2391029 by hass: Attaching inline JS no longer possible.
hass’s picture

hass CreditAttribution: hass commented

Patch will be rolled back later to intentionally break the module and get inline JS back into core.

The last submitted patch, 5: google_analytics_inline_js.patch, failed testing.

The last submitted patch, 7: google_analytics_inline_js-2391029-7.patch, failed testing.

hass’s picture

hass CreditAttribution: hass commented
Status: Postponed » Fixed

add html head has weight now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.