Problem/Motivation

As per #2183983: Find hidden configuration schema issues most of the remaining fails are either in migrate or config itself. This issue is for the config fails. See #2358269: Migration bugs in block visibility, field overrides, cron, maintenance settings and form modes found by configuration schema checking for migrate.

Proposed resolution

1. Add strict checking to affected config system tests.
2. Fix the fails.

Remaining tasks

Fix fails. Review. Commit.

User interface changes

None.

API changes

Config schemas fixed as appropriate.

Files: 
CommentFileSizeAuthor
#19 2391021-config-schema-15.patch13.76 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,188 pass(es). View
#16 interdiff.txt584 bytesGábor Hojtsy
#16 2391021-config-schema-15.patch13.76 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Failed to run tests: failed during invocation of run-tests.sh. View
#14 2391021-config-schema-14.patch13.87 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,185 pass(es). View
#13 2391021-config-schema-12.patch12.7 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Setup environment: Test cancelled by admin prior to completion. View
#11 interdiff.txt475 bytesGábor Hojtsy
#11 2391021-config-schema-10.patch14.18 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2391021-config-schema-10.patch. Unable to apply patch. See the log in the details link for more information. View
#9 interdiff.txt2.89 KBGábor Hojtsy
#9 2391021-config-schema-9.patch13.72 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2391021-config-schema-9.patch. Unable to apply patch. See the log in the details link for more information. View
#7 interdiff.txt3.77 KBGábor Hojtsy
#7 2391021-config-schema-7.patch10.83 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,030 pass(es), 3 fail(s), and 1 exception(s). View
#5 interdiff.txt1.96 KBGábor Hojtsy
#5 2391021-config-schema-5.patch12.66 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,029 pass(es), 4 fail(s), and 1 exception(s). View
#3 2391021-config-schema-3.patch11.63 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,008 pass(es), 4 fail(s), and 2 exception(s). View
#3 interdiff.txt5.36 KBGábor Hojtsy
#1 2391021-config-schema.patch6.75 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,847 pass(es), 3 fail(s), and 13 exception(s). View

Comments

Gábor Hojtsy’s picture

FileSize
6.75 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,847 pass(es), 3 fail(s), and 13 exception(s). View

Status: Needs review » Needs work

The last submitted patch, 1: 2391021-config-schema.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
5.36 KB
11.63 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,008 pass(es), 4 fail(s), and 2 exception(s). View

1. Making some exemptions in schema checking for things that are not or only partially schema covered *by design*.
2. Add a whole bunch of missing things for tested data structures in config_test.schema.yml.
3. Add missing schemas for config_collection_install_test and config_events_test.
4. Add config_test module as a test dependency to ConfigFileContentTest so we have the schema available.

Only one fail seems to be left locally in ConfigDependencyTest. That does not look trivial to me :/ Maybe I am overlooking something.

Status: Needs review » Needs work

The last submitted patch, 3: 2391021-config-schema-3.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
12.66 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,029 pass(es), 4 fail(s), and 1 exception(s). View
1.96 KB

Ok CRUD test has some more stuff.

Status: Needs review » Needs work

The last submitted patch, 5: 2391021-config-schema-5.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
10.83 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,030 pass(es), 3 fail(s), and 1 exception(s). View
3.77 KB

There are too many intricate details of how the tests test schema-less elements, so some config tests will *need* to be exempt from config schema checking to be able to stay sane.

Status: Needs review » Needs work

The last submitted patch, 7: 2391021-config-schema-7.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
13.72 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2391021-config-schema-9.patch. Unable to apply patch. See the log in the details link for more information. View
2.89 KB

Use config_test.schemaless in the tests where we do not want to exempt config_test.noschema from testing, so we can keep it exempt at other config tests while still testing the rest.

Status: Needs review » Needs work

The last submitted patch, 9: 2391021-config-schema-9.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
14.18 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2391021-config-schema-10.patch. Unable to apply patch. See the log in the details link for more information. View
475 bytes

Finally the ConfigQueryTest was initializing the array as null, not an empty array. To fix that for schema, initialize as array.

Status: Needs review » Needs work

The last submitted patch, 11: 2391021-config-schema-10.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
12.7 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Setup environment: Test cancelled by admin prior to completion. View
Gábor Hojtsy’s picture

FileSize
13.87 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,185 pass(es). View

Duh, rolled that wrong. Here is the right one.

The last submitted patch, 13: 2391021-config-schema-12.patch, failed testing.

Gábor Hojtsy’s picture

FileSize
13.76 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Failed to run tests: failed during invocation of run-tests.sh. View
584 bytes

We also don't need the config_test module in ConfigFileContentTest which was only added so we can provide schema, but the things tested there are crazy to provide schema for.

Gábor Hojtsy’s picture

Issue tags: +Ghent DA sprint
alexpott’s picture

Status: Needs review » Reviewed & tested by the community

This looks good to go. @Gábor Hojtsy discussed if it was worth moving the default config_schema_test.noschema.yml to another module but I think not.

Gábor Hojtsy’s picture

FileSize
13.76 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,188 pass(es). View

Reuploading for bot.

The last submitted patch, 16: 2391021-config-schema-15.patch, failed testing.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed ae049e9 on 8.0.x
    Issue #2391021 by Gábor Hojtsy: Config schema issues in config tests...
Gábor Hojtsy’s picture

Thanks!

The last submitted patch, 16: 2391021-config-schema-15.patch, failed testing.

The last submitted patch, 16: 2391021-config-schema-15.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.