Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
configuration system
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
10 Dec 2014 at 23:25 UTC
Updated:
26 Dec 2014 at 17:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
gábor hojtsyComment #3
gábor hojtsy1. Making some exemptions in schema checking for things that are not or only partially schema covered *by design*.
2. Add a whole bunch of missing things for tested data structures in config_test.schema.yml.
3. Add missing schemas for config_collection_install_test and config_events_test.
4. Add config_test module as a test dependency to ConfigFileContentTest so we have the schema available.
Only one fail seems to be left locally in ConfigDependencyTest. That does not look trivial to me :/ Maybe I am overlooking something.
Comment #5
gábor hojtsyOk CRUD test has some more stuff.
Comment #7
gábor hojtsyThere are too many intricate details of how the tests test schema-less elements, so some config tests will *need* to be exempt from config schema checking to be able to stay sane.
Comment #9
gábor hojtsyUse config_test.schemaless in the tests where we do not want to exempt config_test.noschema from testing, so we can keep it exempt at other config tests while still testing the rest.
Comment #11
gábor hojtsyFinally the ConfigQueryTest was initializing the array as null, not an empty array. To fix that for schema, initialize as array.
Comment #13
gábor hojtsyRerolled. Did not apply anymore due to #2363155: content_translation.settings config is not scalable.
Comment #14
gábor hojtsyDuh, rolled that wrong. Here is the right one.
Comment #16
gábor hojtsyWe also don't need the config_test module in ConfigFileContentTest which was only added so we can provide schema, but the things tested there are crazy to provide schema for.
Comment #17
gábor hojtsyComment #18
alexpottThis looks good to go. @Gábor Hojtsy discussed if it was worth moving the default config_schema_test.noschema.yml to another module but I think not.
Comment #19
gábor hojtsyReuploading for bot.
Comment #21
catchCommitted/pushed to 8.0.x, thanks!
Comment #23
gábor hojtsyThanks!