CommentFileSizeAuthor
#4 edit_issue_make_footer-2389607-1.patch460 byteskyletaylored
#2 footer-optional.patch461 bytesjjshoe

Comments

jjshoe’s picture

jjshoe commented

Attached a patch so I don't get a grey line over the top of nothing when I have no footer.

jjshoe’s picture

jjshoe commented
StatusFileSize
new footer-optional.patch461 bytes

Status: Needs review » Needs work

The last submitted patch, 2: footer-optional.patch, failed testing.

kyletaylored’s picture

kyletaylored commented
Title: Make footer optional » Hide footer when region is empty
StatusFileSize
new edit_issue_make_footer-2389607-1.patch460 bytes

You had a small typo. Re-rolled.

kyletaylored’s picture

kyletaylored commented
Status: Needs work » Needs review

brahmjeet789 queued 4: edit_issue_make_footer-2389607-1.patch for re-testing.

brahmjeet789’s picture

brahmjeet789 commented
Status: Needs review » Reviewed & tested by the community
brahmjeet789’s picture

brahmjeet789 commented

The patch #4 is working fine for hides the footer region if there is no content in footer region.

  • markcarver committed 331d546 on 7.x-3.x authored by jjshoe 
    Issue #2389607 by jjshoe, kyletaylored: Hide footer when region is empty
markhalliwell’s picture

markhalliwell
Primary language English
commented
Category: Feature request » Bug report
Status: Reviewed & tested by the community » Fixed
markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: Unassigned » neardark
Status: Fixed » Patch (to be ported)

Needs to be ported to the 8.x branch.

  • markcarver committed 331d546 on 7.x-4.x authored by jjshoe 
    Issue #2389607 by jjshoe, kyletaylored: Hide footer when region is empty
markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 7.x-3.x-dev » 8.x-3.x-dev
neardark’s picture

neardark commented
Assigned: neardark » Unassigned
Status: Patch (to be ported) » Fixed

Looks like this is handled in the twig template already (see below). Marking as fixed.

{% if page.footer %}
  <footer class="footer container" role="contentinfo">
    {{ page.footer }}
  </footer>
{% endif %}

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.