China needs predefined administrative areas (and other tweaks, but let's start here).

CommentFileSizeAuthor
#5 QQ截图20141210233319.png34.6 KBzterry95
#5 QQ截图20141210233342.png36.57 KBzterry95
#2 2389517-1-chinese-administrative-areas_2.patch1.53 KBskyredwang
#1 2389517-1-chinese-administrative-areas.patch1.43 KBbojanz

Comments

bojanz’s picture

bojanz commented
Status: Active » Needs review
StatusFileSize
new 2389517-1-chinese-administrative-areas.patch1.43 KB

Here's a list, taken from Google's (Android/Chrome) dataset.

Does the ordering make sense? Or do we want to use the one in https://en.wikipedia.org/wiki/ISO_3166-2:CN?

skyredwang’s picture

skyredwang
Location Shanghai
commented
StatusFileSize
new 2389517-1-chinese-administrative-areas_2.patch1.53 KB

The ordering from Google is based on Chinese pronouncement alphabet (Chinese pronounce "Macau" as "Aomen", therefore it ranks second)

I added translation function for each province, so they can be translated into Chinese.

Also, different people have different political opinions on how to call a city (For example, Taiwan). Translation gives them one more tool to use their preference.

bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Thanks for the review. The t() function was forgotten, not intentionally left out. Committed your patch :)

  • bojanz committed 0354e40 on 7.x-1.x authored by skyredwang 
    Issue #2389517 by bojanz, skyredwang: Add administrative areas for China
zterry95’s picture

zterry95 commented
StatusFileSize
new QQ截图20141210233342.png36.57 KB
new QQ截图20141210233319.png34.6 KB

The https://www.drupal.org/project/china_address_field has extends this perfectly.

Pls try the 2.x branch. it's total based on the address field.
It support both Pinyin and Chinese.
Support 3 level hierarchical select for China address.

Attachment are proof for this on one of the commerce project, the checkout page.

I think new discussion on China address, we can move to
https://www.drupal.org/project/issues/china_address_field

bojanz’s picture

bojanz commented

@zterry95
We have no plans to add the list of cities and counties to addressfield 1.x, so your module will continue to be the solution for those wanting a more complete Chinese form before addressfield 1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.