Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The simpletest module (\core\modules\simpletest\simpletest.module) is including this component:
use Symfony\Component\Process\PhpExecutableFinder;
But this component went away when updgrading symfony to 2.6 in commit:
SHA-1: 3b945fe250e4af8ff6e121796ba28c9c22b16f04
* Issue #2366043 by dawehner: Upgrade to Symfony 2.6
I believe that it is impossible that this (broken simpletest) passed unaware for more than two weeks, so I am probably having something wrong here, just wanted to make sure....
Proposed resolution
Add the process component as explicit dependency. More details in #2389287-1: Missing PhpExecutableFinder
Remaining tasks
User interface changes
API changes
Original report by @david_garcia
Beta phase evaluation
Issue category | Bug, because tests don't run on windows. |
---|---|
Issue priority | Critical, because we can't even in theory add CI support for windows without being able to run tests. |
Disruption | No disruption at all. |
Comment | File | Size | Author |
---|---|---|---|
#1 | 2389287-1.patch | 188.33 KB | dawehner |
Comments
Comment #1
dawehnerTo be clear, this was not triggered, because this class is just used on windows platforms:
On the other hand, this was never defined in our
composer.json
file.This code though was part of our vendor directoy, because HttpKernel/composer.json has a require-dev dependency to the process component.
Comment #2
david_garcia CreditAttribution: david_garcia commentedTests are working now on windows platform. Thanks.
Comment #3
david_garcia CreditAttribution: david_garcia commentedComment #4
dawehnerComment #5
catchCommitted/pushed to 8.0.x, thanks!
Comment #8
hass CreditAttribution: hass commentedI still cannot run any UnitTest on Windows!?