Problem/Motivation

While writing tests for #2341323: Adapt the references field / table names in views, when corresponding entity schema changes we realized that we have a actually not needed file left: /core/modules/system/tests/modules/entity_test/src/EntityTestViewsData.php

Proposed resolution

  • Remove that file
  • Update /core/modules/system/tests/modules/entity_test/src/Entity/EntityTest.php and remove the line * "views_data" = "Drupal\entity_test\EntityTestViewsData",
    Note: Below is already * "views_data" = "Drupal\views\EntityViewsData"so there is no change in functionality.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#2 remove-2388467-2.patch4.07 KBzaporylie

Comments

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Status: Active » Needs review
StatusFileSize
new remove-2388467-2.patch4.07 KB

If that's all - here is a patch for you.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Perfect, thank you very much!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Removing dead test code so it is allowed per https://www.drupal.org/core/beta-changes. Committed a124604 and pushed to 8.0.x. Thanks!

  • alexpott committed a124604 on 8.0.x 
    Issue #2388467 by zaporylie: Remove \Drupal\entity_test\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.