After reading this blog post (http://www.vdmi.nl/blog/i-went-drupal-733-and-all-i-got-was-slow-site) I decided to apply the patch and see what issues I was getting. I noticed through the call stack that file_scan_directory was called for my base themes. I traced this to icon_api calling drupal_get_path with the non machine name for the theme. For example 'Bootstrap' instead of 'bootstrap'. I have attached some images below to more clearly showcase the problem.
Before Patch:
After Patch:
Resolution: I just simply ensured we were using array_keys to get the base theme name so the lookup in drupal_get_filename in the system table will not fail.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | drupal_7_33_and_icon-2387921-2.patch | 450 bytes | kyletaylored |
| #1 | drupal_7_33_and_icon-2387921-1.patch | 1.19 KB | sylus |
| after.png | 48.84 KB | sylus | |
| before.png | 59.22 KB | sylus |
Comments
Comment #1
sylus commentedAttaching patch.
Comment #2
sylus commentedComment #3
markhalliwellLooks simple enough. Marking as CNW as there are some whitespace changes in the above patch.
Comment #4
kyletaylored commentedre-rolled, and totally works. We were unable to install OE with Icon Beta5 after 7.33 update as the installation would just hang, but now it seems to install just fine.
Comment #5
sylus commentedComment #6
sylus commentedThanks for the reroll without whitespace correction, glad it helped with your issue as well :)
Comment #7
markhalliwell