Let's use format_xml_elements to output an array in writeElement() instead of our custom code. This will help support more advanced elements and output without messing up the results.

CommentFileSizeAuthor
#12 2387557-support-advanced-element-output.patch8.22 KBdave reid
#9 2387557-support-advanced-element-output.patch8.22 KBdave reid
#8 2387557-support-advanced-element-output.patch6.36 KBdave reid
#2 2387557-format-xml-elements.patch1.15 KBdave reid
#1 2387557-format-xml-elements.patch1.3 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2387557-format-xml-elements.patch1.3 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 2387557-format-xml-elements.patch1.15 KB

Final version.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed to 7.x-2.x and 6.x-2.x.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-2.x-dev » 8.x-1.x-dev
Status: Fixed » Patch (to be ported)

  • Dave Reid committed 93070fe on 
    Issue #2387557 by Dave Reid: Support more advanced XML element output...

  • Dave Reid committed 04bc0a9 on 7.x-2.x 
    Issue #2387557 by Dave Reid: Support more advanced XML element output...
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Looks like this is no longer quite so easy with D8: https://www.drupal.org/node/2468139

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 2387557-support-advanced-element-output.patch6.36 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 2387557-support-advanced-element-output.patch8.22 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

My solution for now is just to copy format_xml_elements() and shove it into XmlSitemapWriter. It works for what we need, and we can re-evaluate doing something better.

Status: Needs review » Needs work

The last submitted patch, 9: 2387557-support-advanced-element-output.patch, failed testing. View results

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2387557-support-advanced-element-output.patch8.22 KB

  • Dave Reid committed 6be806d on 8.x-1.x 
    Issue #2387557 by Dave Reid: Support more advanced XML element output.
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #12 to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.