CommentFileSizeAuthor
#7 2387331-6.patch2.48 KBjuampynr
#7 interdiff.txt823 bytesjuampynr
#5 interdiff.txt2.05 KBamateescu
#5 2387331-5.patch2.51 KBamateescu
#4 2387331-xmlsitemap-cron-disable-regeneration-8port-4.patch1.65 KBacrosman
#1 2387331-xmlsitemap-cron-disable-regeneration.patch1.78 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2387331-xmlsitemap-cron-disable-regeneration.patch1.78 KB

  • Dave Reid committed 7b3522f on 7.x-2.x 
    Issue #2387331 by Dave Reid: Make it possible to disable cron...
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-2.x-dev » 8.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed to 7.x-2.x and 6.x.2.x. Needs to be ported to 8.x-1.x.

acrosman’s picture

acrosman
Primary language English
Location South Carolina, US
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 2387331-xmlsitemap-cron-disable-regeneration-8port-4.patch1.65 KB

Port of the patch to the 8.x branch.

amateescu’s picture

amateescu commented
StatusFileSize
new 2387331-5.patch2.51 KB
new interdiff.txt2.05 KB

Updated the patch to include the new setting in our default config as well as in the config schema.

  • juampynr committed 16be96a on 8.x-1.x authored by amateescu 
    Issue #2387331 by amateescu, Dave Reid, acrosman: Make it possible to...
juampynr’s picture

juampynr commented
Status: Needs review » Fixed
StatusFileSize
new interdiff.txt823 bytes
new 2387331-6.patch2.48 KB

Committed. Thanks!

I did a small change though, which was to move this check to the top of the hook implementation. For reference, I am attaching here the interdiff with my change and the committed patch.

amateescu’s picture

amateescu commented

@juampynr, you might want to check out #2606970-13: [xmlsitemap] XML sitemap and https://github.com/amateescu/xmlsitemap/commits/8.x-1.x , I worked a lot on the 8.x version of XML Sitemap to the point where it's actually stable and usable :)

juampynr’s picture

juampynr commented

Good stuff! I will do that.

  • amateescu committed e256351 on 8.x-1.x 
    Issue #2387331 by amateescu, Dave Reid, acrosman: Make it possible to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 4: 2387331-xmlsitemap-cron-disable-regeneration-8port-4.patch, failed testing.

The last submitted patch, 5: 2387331-5.patch, failed testing.

The last submitted patch, 4: 2387331-xmlsitemap-cron-disable-regeneration-8port-4.patch, failed testing.

The last submitted patch, 5: 2387331-5.patch, failed testing.