Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
install system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Dec 2014 at 10:34 UTC
Updated:
18 Dec 2014 at 18:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
alexpottComment #2
yched commentedNit: a comma after "installing a module" would make the sentence easier to parse ?
Other than that, I'm not really familiar with the installer not the theme negociation, but this "looks good"...
Temptative RTBC, and maybe core committers can think of a more appropriate person to vet this ?
Comment #3
alexpottFixed comment. Actually the
ifis superfluous since this is checked in_drupal_maintenance_theme()Talked about this with @dawehner in IRC. He suggested adding a @todo to remove all the maintenance theme setting in the installer and override this on the container level. However I feel that is way beyond the scope of this issue. We would have to add the @todo's to all the places in the installer where the maintenance theme is initialised. The patch attached continues to fix this in the same way as in other places in the installer. For example, see install_display_output()
Comment #4
catchCommitted/pushed to 8.0.x, thanks!