Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
tracker.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Dec 2014 at 18:40 UTC
Updated:
16 Jan 2015 at 23:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
areke commentedComment #2
perennial.sky commentedLooks good to me.
Comment #3
cilefen commented$this->comment in TrackerTestBase is not declared or documented.
Comment #4
hussainwebFixed as per #3.
Comment #5
hussainwebForgot to set to needs review.
Comment #6
tibbsa commentedMy only nit-pick is in TrackerTest.php; suggest:
Other than that, this should be good to go.
Comment #7
rpayanmComment #8
tibbsa commentedI did not find any other missing variables or docblock issues; setting RTBC.
Comment #9
alexpottThis change is incorrect $admin_user is not a class property.
Comment #10
rpayanmA question:
On core/modules/config/src/Tests/ConfigLanguageOverrideWebTest.php we have this code:
We might change to this:
???
Comment #11
mile23Patch applies, phpcs says there are no inappropriate underscore property names, and addresses the issues of #3, #6, and #9.
Let's check the testbot's reaction since the last run is a little stale.
Comment #13
mile23Testbot believes.
Comment #16
mile23Still passes.
Comment #17
alexpottCommitted 7aad4bc and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.