Problem/Motivation

Bartik's CKEditor iframe stylesheet is not being loaded ever since Classy was added as a Bartik base theme. Consequently, image captions in CKEditor look broken at the moment.

(At /node/add/article, inspect CKEditor's iframe, its <head> tag does not list a core/themes/bartik/css/ckeditor-iframe.css stylesheet, but it should.)

All due to one misplaced comma, that has been misplaced since its introduction on February 8, 2013, almost 2 years ago, in #1890502: WYSIWYG: Add CKEditor module to core.

Proposed resolution

Fix + test.

Remaining tasks

Patch.

User interface changes

Un-fubar image captions in CKEditor.

API changes

None.

CommentFileSizeAuthor
#6 Screen Shot 2014-12-08 at 8.26.52 PM.png489.67 KBtadityar
#6 Screen Shot 2014-12-08 at 8.23.36 PM.png478.13 KBtadityar
#2 2385111-2.patch1.92 KBwim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Bartik's CKEditor iframe stylesheet is not being loaded ever since Classy was added as a Bartik base theme » Bartik's CKEditor iframe stylesheet is not being loaded
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Issue summary: View changes
Status: Active » Needs review
Issue tags: +Quickfix
StatusFileSize
new 2385111-2.patch1.92 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Bartik's CKEditor iframe stylesheet is not being loaded » Bartik's CKEditor iframe stylesheet is not being loaded, hence image captions look broken
Bojhan’s picture

Bojhan commented

Before and after screen here would probably suffice for RTBC

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Novice

NW for the screenshots asked for in #4.

tadityar’s picture

tadityar commented
Status: Needs work » Needs review
StatusFileSize
new Screen Shot 2014-12-08 at 8.23.36 PM.png478.13 KB
new Screen Shot 2014-12-08 at 8.26.52 PM.png489.67 KB

before after

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thank you! :)

Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community

Awesome, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 68baffe and pushed to 8.0.x. Thanks!

  • alexpott committed 68baffe on 8.0.x 
    Issue #2385111 by tadityar, Wim Leers: Bartik's CKEditor iframe...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.