Menu block - menu level and depth are not saved

Confirming the bug and the fix.

Looks like we need a test here - no?

Also this feels like a critical piece of functionality is not working.

Working on tests

hoping for red/green

+++ b/core/modules/menu_ui/src/Tests/MenuTest.php
@@ -867,4 +876,18 @@ private function verifyAccess($response = 200) {
+    $this->assertFieldByName('settings[depth]', 3);

We are only checking depth can we add level assert as well?

sure

Thanks.

+++ b/core/modules/menu_ui/src/Tests/MenuTest.php
@@ -867,4 +876,20 @@ private function verifyAccess($response = 200) {
+      'settings[level]' => 2,
...
+    $this->assertFieldByName('settings[level]', 2);

I think this broke the other test :)

ya

take 4

+++ b/core/modules/menu_ui/src/Tests/MenuTest.php
@@ -867,4 +876,25 @@ private function verifyAccess($response = 200) {
+      'settings[depth]' => 0,
+      'settings[level]' => 1,

Can't we do it on first attempt and check the values? I think default values are 1 for both depth and level.

The values in the final submit are the defaults.
So we need to submit something else to test it saves.

+++ b/core/modules/menu_ui/src/Tests/MenuTest.php
@@ -867,4 +876,25 @@ private function verifyAccess($response = 200) {
+    $this->assertFieldByName('settings[depth]', 3);
+    $this->assertFieldByName('settings[level]', 2);
+    // Reset settings.
+    $this->drupalPostForm(NULL, [
+      'settings[depth]' => 0,
+      'settings[level]' => 1,
+    ], t('Save block'));
+  }

So what about looking at the final configuration entity in order to see whether things got saved?

So what about looking at the final configuration entity in order to see whether things got saved?

Block->settings is protected so we can't

But there is:

ConfigEntityBase::get()

as well as

$block->getPlugin()->getConfiguration()

like so?

+1

Let's be honest this critical is kinda a quickfix.

Last interdiff is a delight thanks @dawehner for the suggestion @larowlan++
+1 RTBC.

Committed/pushed to 8.0.x, thanks!