Comments

legolasbo’s picture

Status: Needs review » Reviewed & tested by the community

Seems like a no brainer to me.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

http://www.vocabulary.com/dictionary/revert

But...

    drupal_set_message(t('@type %title has been reverted back to the revision from %revision-date.', array('@type' => node_get_type_label($this->revision), '%title' => $this->revision->label(), '%revision-date' => format_date($original_revision_timestamp))));

in \Drupal\node\Form\NodeRevisionDeleteForm

You will also need to fix \Drupal\node\Tests\NodeRevisionsAllTest and \Drupal\node\Tests\NodeRevisionsTest

ricovandevin’s picture

Assigned: Unassigned » ricovandevin

I'll have a look at the tests.

jacob.embree’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new8.84 KB

Removes all inappropriates uses of the word "back" from "[Rr]evert.*back".

ricovandevin’s picture

Assigned: ricovandevin » Unassigned

Status: Needs review » Needs work

The last submitted patch, 4: node-help-redundancy-2.patch, failed testing.

jacob.embree’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new8.84 KB

Reroll

lhangea’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and also I didn't find any other places in core containing this redundancy.

alexpott’s picture

Title: Redundancy in node_help() » Revert back is redundant
Category: Bug report » Task

Retitling so that the issue title fits the patch. Also redundancy is not a bug.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
  1. +++ b/core/modules/quickedit/js/views/EditorView.js
    @@ -163,7 +163,7 @@
    -     * Reverts the modified value back to the original value (before editing
    +     * Reverts the modified value to the original value (before editing
          * started).
    

    Let's change this to * Reverts the modified value to the original value, before editing started. so it fits our standard.

  2. +++ b/core/modules/views_ui/src/Tests/OverrideDisplaysTest.php
    @@ -182,7 +182,7 @@ function testRevertAllDisplays() {
    -    // Revert the title of the block back to the default ones, but submit some
    +    // Revert the title of the block to the default ones, but submit some
         // new values to be sure that the new value is not stored.
    

    Comment should be reflowed.

ajits’s picture

Status: Needs work » Needs review
Issue tags: +#drupalgoa2015
StatusFileSize
new574 bytes
new8.94 KB
  1. Done.
  2. Can you please clarify what needs to be done here? The comment fits the coding standards and is 74 chars wide.
alexpott’s picture

Status: Needs review » Needs work

@Ajit re point 2 new from the following line can be moved to the line that is being changed.

+++ b/core/modules/quickedit/js/views/EditorView.js
@@ -163,8 +163,8 @@
-     * Reverts the modified value to the original value (before editing
-     * started).
+     * Reverts the modified value to the original value, before editing
+     * started.

I think started, will now fit on the first line.

ajits’s picture

Status: Needs work » Needs review
StatusFileSize
new907 bytes
new9.05 KB

Thank you @Alex!
I have moved new from to the line that is being changed.
Couldn't move started above because the line length would then become 81.

miro_dietiker’s picture

Status: Needs review » Reviewed & tested by the community
+++ b/core/modules/quickedit/js/views/EditorView.js
@@ -163,8 +163,8 @@
+     * Reverts the modified value to the original value, before editing
+     * started.

We could reduce "original value" to "original" only to make it fit to one line.

But from the previous discussion, all is properly implemented.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

This issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary. It's allowable because we're not in string freeze. Also it would be great if the patch can be rerolled to have @miro_dietiker's suggested fix in #15 in.

ajits’s picture

StatusFileSize
new559 bytes
new9.04 KB

Implementing the suggestion from #15.
I am not sure if I should set the status of the issue to needs review before updating the issue summary. So leaving the status as is.

jacob.embree’s picture

Issue summary: View changes
Status: Needs work » Needs review

Attempted Beta Evaluation Summary.

Status: Needs review » Needs work

The last submitted patch, 17: revert_back_is_redundant-2383015-17.patch, failed testing.

Status: Needs work » Needs review
lhangea’s picture

Status: Needs review » Reviewed & tested by the community

Because this patch applies cleanly, implements all the suggested changes and translated strings are unfrozen in beta I will set this as RTBC .

wim leers’s picture

Priority: Normal » Minor
Issue tags: +Quickfix
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 8acb057 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 8acb057 on 8.0.x
    Issue #2383015 by AjitS, jacob.embree: Revert back is redundant
    
nod_’s picture

Issue tags: +JavaScript
jacob.embree’s picture

Version: 8.0.x-dev » 7.x-dev
Issue summary: View changes
Status: Fixed » Needs review
Issue tags: +Novice
StatusFileSize
new3.18 KB

Here is a patch for Drupal 7.

ram4nd’s picture

Status: Needs review » Needs work

First comment needs a dot in the end.

pushpinderchauhan’s picture

Status: Needs work » Needs review
StatusFileSize
new3.18 KB
new513 bytes

#27 suggestion incorporated.

sachinwable’s picture

Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

Status: Reviewed & tested by the community » Needs work

I think some of these could be considered end-user-facing strings (depends on the site; they are kind of in between) so based on https://www.drupal.org/node/1527558 we probably shouldn't be changing them and breaking translations in the middle of a stable release, given that this is a minor issue and not really a bug.

If it's a purely admin-facing string though, or certainly any examples that occur in code comments rather than the user interface, those we could still fix :)

  • alexpott committed 8acb057 on 8.1.x
    Issue #2383015 by AjitS, jacob.embree: Revert back is redundant
    
sivaji_ganesh_jojodae’s picture

Based on comment #30 I think we will mark this issue as won't fix.

  • alexpott committed 8acb057 on 8.3.x
    Issue #2383015 by AjitS, jacob.embree: Revert back is redundant
    

  • alexpott committed 8acb057 on 8.3.x
    Issue #2383015 by AjitS, jacob.embree: Revert back is redundant
    
sutharsan’s picture

Issue tags: -Novice

Removing Novice task, issue currently too long for novice.

stefan.r’s picture

Status: Needs work » Closed (won't fix)

Tentatively marking this as won't fix based on #30 -- feel free to reopen if you disagree :)