Closed (won't fix)
Project:
Drupal core
Version:
7.x-dev
Component:
node system
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Nov 2014 at 05:59 UTC
Updated:
28 Sep 2016 at 22:02 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
legolasboSeems like a no brainer to me.
Comment #2
alexpotthttp://www.vocabulary.com/dictionary/revert
But...
in \Drupal\node\Form\NodeRevisionDeleteForm
You will also need to fix \Drupal\node\Tests\NodeRevisionsAllTest and \Drupal\node\Tests\NodeRevisionsTest
Comment #3
ricovandevin commentedI'll have a look at the tests.
Comment #4
jacob.embree commentedRemoves all inappropriates uses of the word "back" from "[Rr]evert.*back".
Comment #5
ricovandevin commentedComment #8
jacob.embree commentedReroll
Comment #9
lhangea commentedPatch applies cleanly and also I didn't find any other places in core containing this redundancy.
Comment #10
alexpottRetitling so that the issue title fits the patch. Also redundancy is not a bug.
Comment #11
alexpottLet's change this to
* Reverts the modified value to the original value, before editing started.so it fits our standard.Comment should be reflowed.
Comment #12
ajitsComment #13
alexpott@Ajit re point 2
newfrom the following line can be moved to the line that is being changed.I think
started,will now fit on the first line.Comment #14
ajitsThank you @Alex!
I have moved
newfrom to the line that is being changed.Couldn't move
startedabove because the line length would then become 81.Comment #15
miro_dietikerWe could reduce "original value" to "original" only to make it fit to one line.
But from the previous discussion, all is properly implemented.
Comment #16
alexpottThis issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary. It's allowable because we're not in string freeze. Also it would be great if the patch can be rerolled to have @miro_dietiker's suggested fix in #15 in.
Comment #17
ajitsImplementing the suggestion from #15.
I am not sure if I should set the status of the issue to needs review before updating the issue summary. So leaving the status as is.
Comment #18
jacob.embree commentedAttempted Beta Evaluation Summary.
Comment #21
lhangea commentedBecause this patch applies cleanly, implements all the suggested changes and translated strings are unfrozen in beta I will set this as RTBC .
Comment #22
wim leersComment #23
alexpottCommitted 8acb057 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.
Comment #25
nod_Comment #26
jacob.embree commentedHere is a patch for Drupal 7.
Comment #27
ram4nd commentedFirst comment needs a dot in the end.
Comment #28
pushpinderchauhan commented#27 suggestion incorporated.
Comment #29
sachinwable commentedComment #30
David_Rothstein commentedI think some of these could be considered end-user-facing strings (depends on the site; they are kind of in between) so based on https://www.drupal.org/node/1527558 we probably shouldn't be changing them and breaking translations in the middle of a stable release, given that this is a minor issue and not really a bug.
If it's a purely admin-facing string though, or certainly any examples that occur in code comments rather than the user interface, those we could still fix :)
Comment #32
sivaji_ganesh_jojodae commentedBased on comment #30 I think we will mark this issue as won't fix.
Comment #35
sutharsan commentedRemoving Novice task, issue currently too long for novice.
Comment #36
stefan.r commentedTentatively marking this as won't fix based on #30 -- feel free to reopen if you disagree :)