Closed (fixed)
Project:
Rules
Version:
7.x-2.x-dev
Component:
Rules Core
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Nov 2014 at 23:54 UTC
Updated:
14 Sep 2018 at 00:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
hctomHere is the patch...
Comment #2
tr commentedYeah, it's not just taxonomy.rules.inc - a quick look shows that there are several include files containing classes or interfaces that are not listed in the .info file with a files[] declaration. Likewise, there is at least one file that IS listed in the .info that doesn't exist - includes/rules.dispatcher.inc
The rules.info file needs to be reviewed, and changes made so that ALL classes and interfaces are declared here, and there are no declarations of include files that don't exist or don't contain classes or interfaces.
Reference https://www.drupal.org/docs/7/creating-custom-modules/writing-module-inf... for the proper use of the files[] declaration.
Comment #3
tr commentedHere are some of the unneeded files[] declarations, as reported by phpcs (see the automated tests tab on the project page):
rules_admin/rules_admin.info
5 It's only necessary to declare files[] if they declare a class or interface.
6 It's only necessary to declare files[] if they declare a class or interface.
rules_scheduler/rules_scheduler.info
6 It's only necessary to declare files[] if they declare a class or interface.
7 It's only necessary to declare files[] if they declare a class or interface.
8 It's only necessary to declare files[] if they declare a class or interface.
9 It's only necessary to declare files[] if they declare a class or interface.
12 It's only necessary to declare files[] if they declare a class or interface.
13 It's only necessary to declare files[] if they declare a class or interface.
tests/rules_test.info
6 It's only necessary to declare files[] if they declare a class or interface.
Comment #4
tr commentedI think this covers everything. I'd like a review to ensure I didn't miss anything that should be there or include anything that shouldn't be there ...
Comment #6
tr commentedCommitted.