Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Here's an initial patch from D5-D6.
Comment | File | Size | Author |
---|---|---|---|
#18 | d6port_1.patch | 5.97 KB | nathan.zhu |
boost d5 to d6 portd6 | 8.94 KB | bhuga | |
Comments
Comment #1
Arto CreditAttribution: Arto commentedComment #2
bhuga CreditAttribution: bhuga commentedThis patch has strange errors related to drupal_get_path() with a database type of mysqli but is working fine for me with mysql.
Comment #3
benjamine_df CreditAttribution: benjamine_df commentedQuick test the patch works fine.
After applying the patch, don't forget to run the module 'update' in the administartion page.
Comment #4
giorgio79 CreditAttribution: giorgio79 commentedWill this be put in the releases section?
Comment #5
wobbler CreditAttribution: wobbler commented--edit - created a support request for this issue. http://drupal.org/node/276060
I went from 4 pages a sec to 250 pages a second with this module, which is absolutely fantastic, but it only caches the front page, it not any the others.
I have multiple sites, with the module only turned on for two out of three sites. The cache directory has the different domains, but only the index.html file and a symbolic link to home.html which is the clean url for the home page aswell.
There are no errors in the log files, is there any way to debug it?
Also one thing, When I used the example htaccess entries, I had to change the RewriteRule lines to add %{DOCUMENT_ROOT}/ to the begining, this is because I am using a conf file, rather than htaccess files.
RewriteRule ^(.*)$ cache/%{SERVER_NAME}/0/index.html [L]
to
RewriteRule ^(.*)$ %{DOCUMENT_ROOT}/cache/%{SERVER_NAME}/0/index.html [L]
Comment #6
wobbler CreditAttribution: wobbler commentedOk forget the above comment, I figured out the problem, and it wasn't the Boost code, see http://drupal.org/node/276060. I now have the patched code working, and like everyone else I think it works fine.
Comment #7
wobbler CreditAttribution: wobbler commentedIf I use the Admin -> Performance -> Boost pages to try and set the cacheability settings to 'except' a page the form submission fails, giving the error... (It actually fails whenever I try to submit the page, whatever the settings are.)
PHP Fatal error: Cannot use string offset as an array in /usr/share/drupal-6.3/includes/form.inc on line 966
That line is
$form['#attributes']['disabled'] = 'disabled';
in the
_form_builder_handle_input_element
function. http://api.drupal.org/api/function/_form_builder_handle_input_element/6 , I don't understand why that particular line is being evaluated. I have got around the problem for now by hardcoding the page I don't want cached in the boost.module file.Comment #8
MatthijsG CreditAttribution: MatthijsG commentedI see that the patch is a diff-file ?? I'm not familiar with diffs. Can someone send me simply a .tar of the module-folder? You would help me and other people... I'm willing to host that tar on my site for other people (and of course, i'm making a link in this node to my host).
Comment #9
wobbler CreditAttribution: wobbler commentedLenn-art, To apply the diff file is very quick, copy the d6port.patch file into the boost module directory and run:
patch -p0 < d6port.patch
It will list the patched files once complete, it should only take a second.
Comment #10
MatthijsG CreditAttribution: MatthijsG commentedFirst of all, is patch a command in Linux or Windows? And where can i run this? And how should i do this when i'm using a webhoster ;-) ?
Comment #11
cybe CreditAttribution: cybe commentededit: disregard this message
Comment #12
chirale CreditAttribution: chirale commentedThis issue was open 5 month ago. Is that patch ready for production use? When Drupal 6 port is planned to be listed on release section? Thanks.
Comment #13
pbull CreditAttribution: pbull commentedWhat's holding up a Drupal 6 release? This patch is pretty complete, I've had to make some adjustments but I've got Boost running on a well-trafficked production site and would like to submit my changes and get some more momentum behind this project... but I think it's counterproductive for me to be submitting patches to a patch.
Comment #14
moshe weitzman CreditAttribution: moshe weitzman commentedHi Peter.
It is true that there is basically no maintainer for this module. We need to fix that. At the same time, there is no patch for D6 that is in RTBC status so a busy maintainer could rightfully just let this issue lie until thats here.
So, please do submit a new patch all the changes needed for d6 and then get someone to review it. Once it is RTBC, we can request Arto to review it if he doesn't on his own.
Comment #15
chirale CreditAttribution: chirale commentedI'm waiting for Peter's adjusted patch too, and ready to test it. So after some tests we can move it to RTBC building the first 6.x release?
Comment #16
pbull CreditAttribution: pbull commentedOk, so what's the recommended approach? Should I submit a patch against the 5.x-1.0 release, or against the patched D6 version?
Comment #17
moshe weitzman CreditAttribution: moshe weitzman commentedThe released version, please.
Comment #18
nathan.zhu CreditAttribution: nathan.zhu commentedfirst, thanks you improve this module work with drupal6, great work, The strong problem about
PHP Fatal error: Cannot use string offset as an array in /usr/share/drupal-6.3/includes/form.inc on line 966
I am still not sure where is problem the default function can't accept the input message. very very strong problem but use some old method this part work well. So, i add new patch for it, let most user use this module in drupal6.
Comment #19
najibx CreditAttribution: najibx commentedcool ...will try it once I had my site move to D6. Great module and not to be missed :-)
Comment #20
chirale CreditAttribution: chirale commented#18 seems only works with "node/xxx" and not with URL aliases. As anonymous, visiting node/xxx equivalent of an aliased page return the cached version, visiting aliased page rebuild the entire page without passing from Boost.
Comment #21
zilla CreditAttribution: zilla commentedany chance that this could be released to the home page as a d6 alpha or just d6-compatible 'head version' for users to try out? i'm no good at patching, but would gladly try this out on a dev site running all sorts of views/cck/stuff to see how it improves load times...
Comment #22
chrism2671 CreditAttribution: chrism2671 commentedI agree- a D6 alpha would be a great step forward!
Comment #23
Flying Drupalist CreditAttribution: Flying Drupalist commented#18 is recommended right?
Comment #24
Arto CreditAttribution: Arto commentedComment #25
Chris Johnson CreditAttribution: Chris Johnson commentedThe patch in #18 looks good by visual inspection. Getting a -dev version people could test would be nice.
Comment #26
sidharth_k CreditAttribution: sidharth_k commentedsubscribing
Comment #27
jrabeemer CreditAttribution: jrabeemer commentedsub
Comment #28
Arto CreditAttribution: Arto commentedThere is now a preliminary 6.x-1.x-dev branch available in CVS. The release node should be available within 12 hours and the CVS log contains the list of changes. I started from Ben's original patch and have credited him with the port as there wasn't any relevant difference in #18 as far as I could see.
I would recommend holding off for at least the first 6.x alpha release, but any brave souls who absolutely must try this out immediately are, of course, free to do so.
Please note that I won't be considering any feature requests at this stage; for the moment I'm only interested in quality assurance (bug fixes, unit tests, documentation, etc), and since I don't have a whole lot of copious free time to test this out on a range of unlikely setups & configurations, well-justified RTBC patches are that much closer to receiving attention than mere bug reports (of which we already have plenty in the issue queue). Contributors posting good patches will be rewarded with CVS access and co-maintainership of the module should they be interested.
Comment #29
juan_g CreditAttribution: juan_g commentedThank you very much! Is the Support locale and multilang sites patch -or similar- included in the 6.x-1.x-dev branch?
That patch has been recommended in the recent and interesting article Improving Drupal's Performance with the Boost Module for the UN's Millennium Campaign.
Comment #30
Arto CreditAttribution: Arto commentedI've just released 6.x-1.0-alpha1.
@Juan, that is not included (yet). I will consider committing any patch marked RTBC, but I may not have the time to go through too many other open issues in the queue, as there are simply too many of them. But see http://drupal.org/project/boost for a list of people with CVS access - I imagine the Development Seed guys might be committing multilanguage-related patches soon.
Comment #31
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #32
deverman CreditAttribution: deverman commentedJust wanted to post that I could really use the multilingual support added to boost.
Comment #33
rsvelko CreditAttribution: rsvelko commentedthis is in the plan - http://drupal.org/node/196266#comment-1076602
changing it back to closed