Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
#2392559: Remove all uses of file_stream_wrapper_get_* and file_get_stream_wrappers
In this issue, let's remove the functions itself.
file_stream_wrapper_get_class
file_stream_wrapper_get_instance_by_uri
file_stream_wrapper_get_instance_by_scheme
file_get_stream_wrappers
Beta phase evaluation
Issue priority | Normal as the patch removes no longer used, already deprecated, functions |
---|---|
Prioritized changes | code already marked for removal by 8.0.0 |
Comment | File | Size | Author |
---|---|---|---|
#16 | 2382859-16.patch | 7.31 KB | rpayanm |
#16 | 2382859-interdiff.txt | 759 bytes | rpayanm |
Comments
Comment #1
rpayanmComment #2
ianthomas_ukfile_get_mimetype() was handled by #2388749: Register symfony's mime guessers if they are supported
Comment #3
mondrake#2392559: Remove all uses of file_stream_wrapper_get_* and file_get_stream_wrappers landed, so this can now be set to active.
Comment #4
rpayanmComment #5
rpayanmPlease review.
Comment #6
mondrakeActually, it looks like some documentation that is in
file.inc
was not moved toStreamWrapperManagerInterface
:for
::getViaUri
, andfor
::getViaScheme
The docs in
StreamWrapperManagerInterface
is much more bare bone and I wonder if the one in file.inc that we are dropping should be added back there.Comment #7
rpayanmComment #8
rpayanmComment #9
mondrakeThank you @rpayanm!
Nit - over 80 chars
This too
Comment #10
mondrakeAdded beta evaluation
Comment #11
rpayanmPlease you can suggest a new sentence, my English is no so good and this must be in one line.
Comment #12
mondrake:) I'm also not a native :)
Suggestion:
Returns a reference to the stream wrapper class responsible for an URI.
Comment #13
rpayanmhehe your english is better :)
Here the patch.
Comment #14
mondrakeApplied the patch and grepped the code base for 'file_stream_wrapper_get' and 'file_get_stream', no results.
Some documentation moved from file.inc to StreamWrapperManagerInterface.
Looks ready to go, RTBC
Comment #15
ianthomas_uk"a URI" is better English than "an URI" (assuming everyone says the letters, you could argue for "an URL" because some people pronounce that like "an earl", but I think most people would spell out URI).
Comment #16
rpayanmsuggestion of @ianthomas_uk
Comment #17
xjmThanks for moving the documentation over from the functions and for the beta evaluation.
As a removal of code that was deprecated for 8.0.0 before the beta, this patch is a prioritized change during the beta. Committed and pushed to 8.0.x. Thanks!