API page: https://api.drupal.org/api/drupal/core%21modules%21system%21theme.api.ph...

The first parameter is sometimes written as $page and $page_top instead of $page_bottom.

The parameter should be similar to https://api.drupal.org/api/drupal/core%21modules%21system%21theme.api.ph...

CommentFileSizeAuthor
#1 drupal8-hook_page_bottom-2382497-1.patch611 bytespushpinderchauhan

Comments

pushpinderchauhan’s picture

pushpinderchauhan commented
Status: Active » Needs review
StatusFileSize
new drupal8-hook_page_bottom-2382497-1.patch611 bytes

Also corrected variable name in attached patch.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs review » Reviewed & tested by the community

The patch makes hook_page_bottom have the same pattern as hook_page_top. Which improves DX (a little).

Patch looks good to me.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Minor
Issue tags: +Quickfix

Oops! Looks good :)

P.S.: Note that the PHP language in general allows you to rename the receiving parameter to anything you like. This applies to hooks, interface implementations, subclasses, etc.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Documentation changes are unfrozen as part of https://www.drupal.org/core/beta-changes. Committed b0c6ff8 and pushed to 8.0.x. Thanks!

  • alexpott committed b0c6ff8 on 8.0.x 
    Issue #2382497 by er.pushpinderrana: The first parameter of the hook...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.