Patch (to be ported)
Project:
Salsa API
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Nov 2014 at 10:50 UTC
Updated:
6 May 2015 at 08:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
berdirThis would also allow us to nicely ignore the problem that delete returns an invalid response at the moment
Comment #2
devlada commentedRegarding to invalid response, are you referring to something like
The first line looks like debug message, and these have been affected supporter and donation objects as I can see, and probably some others. I can remove simplexml_load_string() part, but we will left without any information about deleted records. I'm not sure whether we need to deal with it, in salsa_entity to check whether the objects are removed or not before we proceed any further.
Comment #3
berdirYes, remove the parsing/loading. Or explicitly comment it out and add a @todo and explain that the page currently returns debug messages that break the parsing.
Comment #4
devlada commentedUpdated patch (commented parsing / loading).
Comment #5
berdirI'm not sure why you made $keys an optional argument? Just make it required and you don't need this check/exception?
Comment #6
berdirlet's follow the new coding standards. So include a type, like @param string $object and @param array $keys.
Comment #7
devlada commentedUpdates related to #5 and #6.
Comment #9
berdirThanks, made a few comment/documentation improvements (no need for return value) and committed.