In #2374125: Create a persistent block_content body field storage we stopped adding body fields by default but I forgot to add the configuration to the standard profile. This issue will add the default configuraiton.

CommentFileSizeAuthor
#6 block-body-test-2381909.w-tests.patch3.25 KBlarowlan
#5 block-body-test-2381909.w-tests.patch127.96 KBlarowlan
#5 interdiff.txt737 byteslarowlan
#1 2381909.1.patch2.53 KBalexpott

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Related issues: +#2374125: Create a persistent block_content body field storage
StatusFileSize
new 2381909.1.patch2.53 KB

I thought about adding a test to the StandardTest but this feels overkill - we have the configuration - the field will exist - there is plenty of configuration in the standard profile that is not "tested".

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Love that this is all yaml

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Should we have tests for this (against the Standard profile)?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: Unassigned » larowlan

adding a test

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: larowlan » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt737 bytes
new block-body-test-2381909.w-tests.patch127.96 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new block-body-test-2381909.w-tests.patch3.25 KB

meh, merge lee merge

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Well fine - but I did argue in #1 that tests weren't necessary - or actually I'd rather add a generic test to StandardTest to ensure that all configuration in the standard profile is created as expected. but lets move on here.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: -Needs tests
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs followup

Committed the patch in #6! Thanks you. Let's open a follow-up issue for the generic test(s).

  • Dries committed 8839de5 on 8.0.x 
    Issue #2381909 by larowlan, alexpott: Basic block type provided by...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.