Clean-up Text module test members - ensure property definition and use of camelCase naming convention

Looks like you missed a usage in TextFieldTest.php line 115

@GPrince17: See the update to the parent issue.

The error was probably due to changing web_user to webUser. I have changed it in the parent class StringFieldTest which is in field module. It is not strictly in the scope of this ticket, but it is a small enough change rather than setting up dependencies to the issue for field module's ticket. We will just need to do a simple reroll depending on which goes in first. There is no issue yet for fixing these issues in the field module, which means we should be fine.

Code looks good. Marking this as RTBC for now.

I am very sorry. This issue needs work.

egrep -rl '\$this\->[a-z]+_[a-z_]+' core/modules/text/src/Tests/
core/modules/text/src/Tests/TextFieldTest.php

That's odd. With this patch applied here, that command does not turn anything up for me.

$ git checkout -b text-test
Switched to a new branch 'text-test'
$ git apply -v ./clean_up_text_module-2380411-9.patch
Checking patch core/modules/field/src/Tests/String/StringFieldTest.php...
Checking patch core/modules/text/src/Tests/TextFieldTest.php...
Applied patch core/modules/field/src/Tests/String/StringFieldTest.php cleanly.
Applied patch core/modules/text/src/Tests/TextFieldTest.php cleanly.
$ egrep -rl '\$this\->[a-z]+_[a-z_]+' core/modules/text/src/Tests/
$

The only thing I could think that might trip this up (though the regexp should keep it from happening) are things like this, but this is valid:

      $entity->{$field_name}->value = str_repeat('x', $i);

Are you sure you tested against a patched copy?

Will recheck it again today. Was a bit sleepy when I was testing this :-)

Marking as RTBC. As tibbsa suggested, I don't think subhojit777 had applied the patch before searching for the text.

$ egrep -rl '\$this\->[a-z]+_[a-z_]+' core/modules/text/src/Tests/
core/modules/text/src/Tests//TextFieldTest.php
$ git apply -v clean_up_text_module-2380411-9.patch
Checking patch core/modules/field/src/Tests/String/StringFieldTest.php...
Checking patch core/modules/text/src/Tests/TextFieldTest.php...
Applied patch core/modules/field/src/Tests/String/StringFieldTest.php cleanly.
Applied patch core/modules/text/src/Tests/TextFieldTest.php cleanly.
$ egrep -rl '\$this\->[a-z]+_[a-z_]+' core/modules/text/src/Tests/
$ 

@areke: Thanks for reviewing. I have not checked this yet. Did you make sure all properties are declared and documented?

adminUser and webUser are not documented.

Added documentation as per #17.

Strictly speaking this should probably have...

* @var \Drupal\user\UserInterface

... for each of the docblocks as well.

Added the fixes to the errors mentioned in #19.

Almost. :)

$ git apply -v clean_up_text_module-2380411-20.patch
clean_up_text_module-2380411-20.patch:13: trailing whitespace.
   * @var \Drupal\user\UserInterface
Checking patch core/modules/field/src/Tests/String/StringFieldTest.php...
Checking patch core/modules/text/src/Tests/TextFieldTest.php...
Applied patch core/modules/field/src/Tests/String/StringFieldTest.php cleanly.
Applied patch core/modules/text/src/Tests/TextFieldTest.php cleanly.
warning: 1 line adds whitespace errors.

Coding standards - Indenting and Whitespace

Did I get it this time? :P

Committed 86ced51 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.