Update the normalize partial based on the latest version of nomalize.css.

CommentFileSizeAuthor
#2 gesso-update-normalize-2380373-2.patch39.03 KBdcmouyard
#1 gesso-update-normalize-2380373-1.patch38.75 KBdcmouyard

Comments

dcmouyard’s picture

dcmouyard commented
Status: Active » Needs review
StatusFileSize
new gesso-update-normalize-2380373-1.patch38.75 KB

This patch updates the normalize styles to match version 3.0.2. I also moved the single element selector styles from normalize into the html-elements partial, in order to cut down on CSS bloat due to multiple calls to the same selector.

dcmouyard’s picture

dcmouyard commented
StatusFileSize
new gesso-update-normalize-2380373-2.patch39.03 KB

Re-rolled the patch so that it applies to the latest dev branch.

adamjuran’s picture

adamjuran commented

Patch applies cleanly but not at all sure how/what to test...

dcmouyard’s picture

dcmouyard commented

One way to test this patch would be to compare how default elements look in Pattern Lab before & after. There shouldn’t be any major visual differences.

dcmouyard’s picture

dcmouyard commented
Priority: Normal » Major
clafferty’s picture

clafferty commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly. Reviewed and tested with clean base theme and site theme currently in development.

  • dcmouyard committed 3d670b9 on 7.x-1.x 
    Issue #2380373 by dcmouyard: Updated normalize partial.
dcmouyard’s picture

dcmouyard commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.