Theme functions and preprocess functions that deal with links, menus, and menu items don’t follow the naming convention 100%. Also, helper classes would be nice to theme menu items that have children and/or a subnav.

CommentFileSizeAuthor
#1 gesso-update-navigation-classes-2380339-1.patch8.04 KBdcmouyard

Comments

dcmouyard’s picture

dcmouyard commented
Status: Active » Needs review
StatusFileSize
new gesso-update-navigation-classes-2380339-1.patch8.04 KB

This patch updates the navigation classes and corresponding styles that used the old classes.

  • Change active class to is-active on links and menu items.
  • Change styles in overridden stylesheets that previously used the active class.
  • Remove menu-mlid-XXX classes from menu items. (These can be manually added back in by uncommenting lines 329-330 in includes/navigation.inc)
  • Add has-children class to menu items that have children within that menu, although those children won’t necessarily be output in the markup.
  • Add has-subnav class to menu items that have a subnav output in the markup.
dcmouyard’s picture

dcmouyard commented
Priority: Normal » Major
clafferty’s picture

clafferty commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly. Reviewed and tested.

  • dcmouyard committed 332f45c on 7.x-1.x 
    Issue #2380339 by dcmouyard: Updated navigation classes.
dcmouyard’s picture

dcmouyard commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.