I use custom Order types in my project, but tax generation function doesn't work, because order type hardcoded there
http://cgit.drupalcode.org/commerce_reports/tree/modules/tax/commerce_re...
http://cgit.drupalcode.org/commerce_reports/tree/modules/tax/commerce_re...

CommentFileSizeAuthor
#1 commerce_reports-any_order_type_support-2380309-1.patch1.95 KBskdrupal88

Comments

skdrupal88’s picture

skdrupal88
Primary language Russian
Location Belarus
commented
Status: Active » Needs review
StatusFileSize
new commerce_reports-any_order_type_support-2380309-1.patch1.95 KB

In my patch I just remove type from Where in query, so function will work for any order type now.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented
Status: Needs review » Reviewed & tested by the community

Thanks @korgik, this patch definately makes sense. Tested at simpletest.me with erpal - works quite well. Any thoughts why was it hardcoded initially?

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Spleshka, it was hardcoded in 3.x and I had kept it that way in 4.x during the overhaul. My main focus was on stability and reliability and clean up of code. I also wasn't sure of all use cases and was looking for community input and patches, such as this!

Thanks guys, I'd like to just give it a test run myself then I'll commit.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

@mglaman, thanks for the explanation, now it is clear. Just a hint - to make your manual test quicker you may use simplytest.me.
Looking forward for your commit! :-)

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Fixed

Trust you guys :) Thanks for contribution, committed!

  • mglaman committed 77bb7bd on authored by korgik 
    Issue #2380309 by korgik: Tax reports - any order types support
spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Thank you for that! ;)

skdrupal88’s picture

skdrupal88
Primary language Russian
Location Belarus
commented

Great, Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 1: commerce_reports-any_order_type_support-2380309-1.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Closed (fixed)

Moving on.