The color module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.
See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.
| Issue category | Task, because this is a coding standards change. |
|---|---|
| Issue priority | Not critical because coding standard changes are not critical. |
| Unfrozen changes | Unfrozen because it only changes automated tests. |
| Disruption | There is no disruption expected from this sort of change. |
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | clean_up_color_module-2379863-4.patch | 1.37 KB | mglaman |
Comments
Comment #1
cilefen commentedComment #2
cilefen commentedComment #3
cilefen commentedComment #4
mglamanOnly instance I could find in color was for
$this->big_user, looks like admin_user was already converted.Comment #5
subhojit777Comment #6
subhojit777Code looks good and ColorTest passed.
Comment #7
alexpottCommitted 4d514be and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.