Closed (fixed)
Project:
Feeds
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Nov 2014 at 00:53 UTC
Updated:
18 Dec 2014 at 20:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
twistor commentedComment #2
megachrizGreat addition!
I tested with a few plugins and it seemed to work very well: I was no longer able to disable a module that provided a Feeds plugin if that plugin was used in a importer (regardless of the importer in question was enabled or disabled and if the importer was in the db or in code). I also checked if the module couldn't be disabled through Drush.
Use static cache?
The function
feeds_system_info_alter()will be called for every module on the system whenever the module admin page is visited, so it will be called a lot. I wonder if we should use static cache for the loaded Feeds importers? I did notice there is some static cache further in the called functions (ctools_get_plugins(),ctools_export_load_object(),FeedsConfigurable::instance()), so maybe there is only little gain.Other causes of FeedsMissingPlugin
Whenever I run into FeedsMissingPlugin issues most times is not by accidentally disable a module that provided a plugin that was in use, but when I enable a module created with the Features module that contains a Feeds importer. In such case I forgot to list all the dependencies that were needed for the Feeds importer when creating the feature, as the dependencies are not automatically detected when putting a Feeds importer in a feature. This is a probably food for an other issue, though.
Comment #4
twistor commentedNothing is loaded unless the module implements hook_feeds_plugins(), which should be a few number of modules.
All of those objects are statically cached someplace else anyway.
Feel like creating that Features issue :)
Comment #5
megachrizAh, I overlooked that first line. Then there is not much point introducing extra static cache indeed.
I put creating the Features issue on my to do list (I should search for existing issues first). Will report here as soon the issue exists.
Comment #6
megachrizI created the follow-up issue for the Features issue I mentioned in #2: #2387419: Auto detect dependencies when putting Feeds importer in a feature.