Regression (again): Menu contextual links no longer visible in menu blocks, when block caching is enabled [#2379083]

It was fixed before in #2239833: Regression: Menu contextual links no longer visible in menu blocks, but it regressed again, despite having test coverage. Somehow it only regressed when blocks are cached.

Please credit olli, who did all the work, I only did a reroll and then moved it into this issue rather than reopening the original issue.

(See #14 and later in #2239833: Regression: Menu contextual links no longer visible in menu blocks.)

Comment	File	Size	Author
#1	2379083-1.patch	2.05 KB	Wim Leers
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 20 November 2014 at 15:59

Status:

Active

» Reviewed & tested by the community

File	Size
2379083-1.patch	2.05 KB

Comment #2

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 21 November 2014 at 09:58

Status:

Reviewed & tested by the community

» Fixed

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed a1a08fe and pushed to 8.0.x. Thanks!

Comment #3

21 November 2014 at 10:00

alexpott committed a1a08fe on 8.0.x

Issue #2379083 by olli, Wim Leers: Regression (again): Menu contextual...

Comment #4

yoroy CreditAttribution: yoroy commented 29 November 2014 at 15:51

Status:

Fixed

» Active

I don't see any other link besides 'Configure block' on my menu block. Caching on or off doesn't seem to matter.

Comment #5

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 29 November 2014 at 15:54

Just to make sure: please clear your caches, try in incognito mode, or try in a different browser. This could be a browser caching problem.

Comment #6

yoroy CreditAttribution: yoroy commented 29 November 2014 at 17:50

Checked in another browser, situation is as described in #4.

Edit: I do see the 'edit menu' link for the core 'Tools' block, but not for my own, newly created menu.

Comment #7

olli CreditAttribution: olli commented 9 December 2014 at 05:35

@yoroy you are right.

+++ b/core/modules/menu_ui/menu_ui.module
@@ -120,7 +120,7 @@ function menu_ui_block_view_system_menu_block_alter(array &$build, BlockPluginIn
   // Add contextual links for system menu blocks.
   $menus = menu_list_system_menus();
   $menu_name = $block->getDerivativeId();
-  if (isset($menus[$menu_name]) && isset($build['content'])) {
+  if (isset($menus[$menu_name])) {
     $build['#contextual_links']['menu'] = array(

That menu_list_system_menus() returns only system-defined (default) menus.

Could you open a new issue?