We have custom tab for Media Browser that uses Ajax calls (drupal ajax). After each ajax call we got switched to Library tab. This happens because when we create tabs in media.browser.js

$('#media-browser-tabset').tabs({
      selected: activeTab, // jquery < 1.9
      active: activeTab, // jquery >= 1.9
      show: showFunc, // jquery ui < 1.8
      activate: showFunc // jquery ui >= 1.8
    });

we do not check if that has happened already.

CommentFileSizeAuthor
#1 media-2378973-jump-to-library-after-ajax-call.patch491 bytesygerasimov

Comments

ygerasimov’s picture

ygerasimov commented
Status: Active » Needs review
StatusFileSize
new media-2378973-jump-to-library-after-ajax-call.patch491 bytes

Attached patch adds once() that fixes the issue.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Thanx, this is a great UI improvements

aaron’s picture

aaron commented

The test bot is down.

andypost’s picture

andypost
he/him
Primary language Russian
commented

yep, that strange. js should not affect testing

andypost’s picture

andypost
he/him
Primary language Russian
commented

@aaron Please commit this quick-fix

  • aaron committed 710e346 on 7.x-2.x 
    Issue #2378973 by ygerasimov: fixed Ajax call switches to Libraries tab
aaron’s picture

aaron commented
Status: Reviewed & tested by the community » Fixed

Committed to http://drupalcode.org/project/media.git/commit/710e346.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.