minor cleanup in CommentManager::addDefaultField() :

- adjust comments (mentions of 'node', field / instance)
- clarifies code organisation a bit
- unifies "does storage exist" / does field exist" checks to use EM::getField[Storage]Definitions()

CommentFileSizeAuthor
#1 2376581-CommentManager_addDefaultField_cleanup-1.patch4.78 KByched

Comments

yched’s picture

yched commented
StatusFileSize
new 2376581-CommentManager_addDefaultField_cleanup-1.patch4.78 KB

Patch

yched’s picture

yched commented
Issue summary: View changes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

works for me

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 17eca96 on 8.0.x 
    Issue #2376581 by yched: Cleanup CommentManager::addDefaultField().

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.