Needs review
Project:
Monitoring
Version:
7.x-1.x-dev
Component:
Sensors
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Nov 2014 at 22:59 UTC
Updated:
10 Oct 2015 at 08:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
berdirA exclude textarea doesn't know what to exclude on? What we should do is expose the operator, and then support IN and a comma separated list?
Comment #2
berdirMight have misread the issue a bit, a generic implementation is not possible but we can use this feature in the dblog and past sensors:
* For those two, add a textfield that says excluded types (for dblog) and excluded machine names for past (past could have two fields, excluded machine names and modules).
* Each line is an entry, you could display a description of known types by collecting them from what's in the database right now (select distinct type... )
* If you have any, exclude in the query you build.
By default, the dblog warning sensor should exclude the 'page not found' type and the error sensor should exclude 'form'. Once we have a php notice sensor, we might also want to exclude php from the notice and warning sensor and track them separately.
Comment #3
miro_dietikerNow we are talking about the same. ;-)
Comment #4
berdirAs discussed with Miro:
In 8.x, we have a conditions UI, that doesn't exist in 7.x. With conditions, you can have a numbers of <> conditions to achieve this.
in 7.x-1.x, we don't have that and will likely not backport it. So a solution as suggested above should probably be implemented in that branch, which requires custom sensor classes for dblog and past.
Comment #5
miro_dietikerBumping this.
Recently we receive many form errors with D7 sites resulting in false positives. Mostly originated by bots that pick invalid values from selects / dropdowns.
Discussed to exclude form errors hardcoded?
Comment #6
berdirNote:
This can be done on 7.x through $conf:
Comment #7
berdirSame for past:
We should probably just add those by default to those two sensors.
Comment #8
giancarlosotelo commentedAdded default conditions to both sensors.
Comment #9
giancarlosotelo commentedComment #10
giancarlosotelo commentedSorry wrong patch.
Comment #13
giancarlosotelo commentedSetting conditions just to 'error'.
Comment #15
giancarlosotelo commentedThis is the way.
Comment #17
giancarlosotelo commentedI checked and fails are related to the commerce module (?)
Comment #18
miro_dietikerYeah right.
Since we can add this through settings (for the relevant sites), i'm just not fully sure if we should really hardcode it or just add it in settings when it happens for a specific site. I still fear that through this general exclude we could end up ignore errors that are originated in buggy code.