FieldConfigBase::calculateDependencies() fatal error is unhelpful

This will be super helpful for Migrate testers as this error keeps popping up and overall improves DX.

+++ b/core/lib/Drupal/Core/Field/FieldConfigBase.php
@@ -248,7 +248,9 @@ public function calculateDependencies() {
+        throw new \LogicException('Missing bundle entity, entity type %type, entity id %bundle.', array('%type' => $bundle_entity_type_id, '%id' => $this->bundle));

Missing String::format()

Re-rolled with String::format() added.

This would have been super-helpful while debugging #2355909: language.settings config is not scalable.

Wow, this patch is amazing. The bad part about this is that this often happens when something goes wrong during the installer and/or migrations. And slowing down these already time-intensive processes by switching on XDebug just to figure out which friggin' entity it couldn't load is super annoying and in aggregate has probably cost me multiple hours already.

+10000

Right, the "Exception thrown during handling of an exception" is nice as well. But I do regularly get this from drush si, maybe the error handling is different there? Don't know. Anyway, I am very enthusiastic about this, I'm not making this up :-)

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed ea24dc5 and pushed to 8.0.x. Thanks!

+++ b/core/lib/Drupal/Core/Field/FieldConfigBase.php
@@ -248,7 +249,9 @@ public function calculateDependencies() {
+        throw new \LogicException(String::format('Missing bundle entity, entity type %type, entity id %bundle.', array('%type' => $bundle_entity_type_id, '%id' => $this->bundle)));

We all missed that this should use %bundle in the array.

Attached patch in the follow-up: #2384665: Follow-up: FieldConfigBase::calculateDependencies() fatal error is unhelpful