Updating Sass (3.4?) and Compass (1.0.1?) will give us a wealth of new features. We also want to update other Sass plugins as necessary (e.g., breakpoint, singularity, etc.)
This issue is a requirement for:
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | gesso-update-sass-compass-2372075-10.patch | 156.38 KB | clafferty |
| #9 | gesso-update-sass-compass-2372075-9.patch | 155.23 KB | clafferty |
| #6 | gesso-update-sass-compass-2372075-6.patch | 130.38 KB | dcmouyard |
Comments
Comment #1
dcmouyard commentedThis patch updates Sass (3.4.13), Compass (1.0.3), Breakpoint (2.5.0), and Singularitygs (1.6.2).
Because the Compass legacy support variables were deprecated, I had to tackle #2366035: How about using Compass 1.x syntax for browser support in this story and update that functionality to use the current practice: http://compass-style.org/reference/compass/support/
Comment #2
dcmouyard commentedComment #3
dcmouyard commentedRe-rolled patch to apply cleanly to 7.x-1.x.
Comment #4
adamjuran commentedDan, can you please give acceptance criteria for this that I can test for? I'm VERY eager to have access to SASS Maps!
Comment #5
dcmouyard commentedApplying this patch shouldn’t affect how things look, yet still give you the new features in Sass and Compass. One way to test would be to compare how default elements look in Pattern Lab before & after. There shouldn’t be any major visual differences. This includes IE8.
Comment #6
dcmouyard commentedRe-rolled the patch so that it applies cleanly to 7.x-1.x.
Comment #7
dcmouyard commentedPatch needs to be re-rolled to apply cleanly to HEAD.
Comment #8
dcmouyard commentedRe-rolled patch so that it applies cleanly to HEAD.
Comment #9
clafferty commentedAdded new syntax for Singularity grids in panels layouts to patch.
Comment #10
clafferty commentedRerolled patch with gradient keyword syntax update (e.g., https://developer.mozilla.org/en-US/docs/Web/CSS/linear-gradient)
Comment #12
dcmouyard commented