Updating Sass (3.4?) and Compass (1.0.1?) will give us a wealth of new features. We also want to update other Sass plugins as necessary (e.g., breakpoint, singularity, etc.)

This issue is a requirement for:

Comments

dcmouyard’s picture

Issue summary: View changes
Status: Active » Needs review

This patch updates Sass (3.4.13), Compass (1.0.3), Breakpoint (2.5.0), and Singularitygs (1.6.2).

Because the Compass legacy support variables were deprecated, I had to tackle #2366035: How about using Compass 1.x syntax for browser support in this story and update that functionality to use the current practice: http://compass-style.org/reference/compass/support/

dcmouyard’s picture

StatusFileSize
new143.85 KB
dcmouyard’s picture

StatusFileSize
new143.88 KB

Re-rolled patch to apply cleanly to 7.x-1.x.

adamjuran’s picture

Dan, can you please give acceptance criteria for this that I can test for? I'm VERY eager to have access to SASS Maps!

dcmouyard’s picture

Applying this patch shouldn’t affect how things look, yet still give you the new features in Sass and Compass. One way to test would be to compare how default elements look in Pattern Lab before & after. There shouldn’t be any major visual differences. This includes IE8.

dcmouyard’s picture

StatusFileSize
new130.38 KB

Re-rolled the patch so that it applies cleanly to 7.x-1.x.

dcmouyard’s picture

Assigned: Unassigned » dcmouyard
Status: Needs review » Needs work

Patch needs to be re-rolled to apply cleanly to HEAD.

dcmouyard’s picture

Assigned: dcmouyard » Unassigned
Status: Needs work » Needs review
StatusFileSize
new137.8 KB

Re-rolled patch so that it applies cleanly to HEAD.

clafferty’s picture

StatusFileSize
new155.23 KB

Added new syntax for Singularity grids in panels layouts to patch.

clafferty’s picture

StatusFileSize
new156.38 KB

Rerolled patch with gradient keyword syntax update (e.g., https://developer.mozilla.org/en-US/docs/Web/CSS/linear-gradient)

  • dcmouyard committed a0760d0 on 7.x-1.x
    Issue #2372075 by dcmouyard, clafferty: Updated to Sass 3.4 and Compass...
dcmouyard’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.