Comments

lewisnyman’s picture

Status: Active » Needs review
Issue tags: +frontend, +CSS
StatusFileSize
new847.17 KB
new426 bytes

It looks like this line of CSS prevents the text from wrapping. I don't understand why this line exists, here's a patch to remove, we should test to see if this breaks anything.

BarisW’s picture

Patch applies nicely and solves the problem. Looks good to me.

ericmulder1980’s picture

Patch applies nicely and after a cache clear results are looking good.

Tested in Chrome 38, Firefox 33.1 and Safari 7.0.6.

ericmulder1980’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs screenshots

Looks like this could remove a lot of CSS...

.locale-translate-edit-form tr .form-item {
  white-space: normal;
}
.field-ui-overview .add-new .form-type-machine-name .description {
  white-space: normal;
}
#permissions tr.odd .form-item,
#permissions tr.even .form-item {
  white-space: normal;
}
#field-display-overview .form-item-fields-field-image-settings-edit-form-settings-image-style {
  white-space: normal;
}

... and maybe more.

It'd be good to find out why that is there.

This was added to misc/drupal.css by the following commit

commit ad5e3ebb75df5c861251ba3ed3dd954a2b2241b4
Author: Steven Wittens <steven@10.no-reply.drupal.org>
Date:   Sun Jul 25 22:18:32 2004 +0000

    CSS improvements:
    - Restoring background coloring for the watchdog logs (was broken)
    - Making watchdog backgrounds lighter, makes it easier on the eyes and improves readability.
    - Adjusted the spacing between items on the frontpage a bit to be clearer.
    - Fixed the vertical stretching of table rows with form controls in them.

So no idea of the issue that prompted the commit :)

BarisW’s picture

Title: Description of display settings takes to much space » Description of display settings takes too much space

Wow, a 2004 commit? I'll try to remove the unneeded CSS too.

BarisW’s picture

Status: Needs work » Needs review
StatusFileSize
new2.36 KB
new1.54 KB

I removed it where possible. On some places, the white-space: nowrap was added on purpose (eg in #system-modules details), so I left these places untouched.

The /admin/reports/translations looks damaged anyhow, even without this patch, but I'll create a new issue for that.

Vally79’s picture

StatusFileSize
new51.81 KB
new44.66 KB

Tried to apply the last patch and it worked until the last 3 lines, which it didn't find in the file. I added those lines manually and verified that the rest of the patch applied successfully. Unfortunately, I don't see any change on Chromium 39.0.2171.65 and Firefox 33.0 on Ubuntu 14.04 LTS.
Chromium

Firefox

tompagabor’s picture

Reroll patch, just remove the first change. Also tested it, and working goood.

andybroomfield’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs screenshots
StatusFileSize
new434.73 KB
new369.42 KB
new399.92 KB

I tested the patch and it fixes the issue (The description text is wrapping now).

webchick’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +SprintWeekend2015

Oh, very nice. We fix a bug *and* delete code at the same time!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 5c16ee7 on 8.0.x
    Issue #2372023 by andybroomfield, BarisW, aspilicious, LewisNyman,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.