The docblock for user_help is wrong—it should read "Implements hook_help().":

/**
 * Implement hook_help().
 */
function user_help($route_name, RouteMatchInterface $route_match) {
CommentFileSizeAuthor
#8 the_docblock_for-2371759-8.patch393 bytesvalentine94
#4 user_help-2371759-3.patch440 bytesangel.angelio

Comments

cilefen’s picture

cilefen commented
Issue tags: +Documentation
cilefen’s picture

cilefen commented
Title: The documentation for user_help() should read "Implements hook_help()." » The docblock for user_help() should read "Implements hook_help()."
Component: documentation » user.module
angel.angelio’s picture

angel.angelio commented

I'm a new contributor at badcamp sprint. I'd like to fix this

angel.angelio’s picture

angel.angelio commented
Status: Active » Needs review
StatusFileSize
new user_help-2371759-3.patch440 bytes

Here's the patch to fix the issue

cilefen’s picture

cilefen commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to 7.x

Nice work on your first contribution.

I am marking this "Needs backport to 7.x", and even though this is a minor change, there is no reason not to fix it in 7.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.0.x-dev » 7.x-dev
Category: Task » Bug report
Status: Reviewed & tested by the community » Patch (to be ported)

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 45c6581 and pushed to 8.0.x. Thanks!

  • alexpott committed 45c6581 on 8.0.x 
    Issue #2371759 by angel.angelio | cilefen: The docblock for user_help()...
valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new the_docblock_for-2371759-8.patch393 bytes

A patch for a 7.x-dev.

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
Issue tags: -Needs backport to 7.x
cilefen’s picture

cilefen commented
Status: Needs review » Reviewed & tested by the community

Thank you @Valentine94.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: the_docblock_for-2371759-8.patch, failed testing.

Status: Needs work » Needs review

cilefen queued 8: the_docblock_for-2371759-8.patch for re-testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: the_docblock_for-2371759-8.patch, failed testing.

cilefen’s picture

cilefen commented
Status: Needs work » Reviewed & tested by the community

That was a spurious testbot failure.

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed b386d92 on 7.x 
    Issue #2371759 by Valentine94, angel.angelio: The docblock for user_help...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.