We have times associated with our RDATEs. When an iCal is generated, it uses the default event RRULE time rather than the actual RDATE entry stored in the Drupal database, resulting in incorrect times on events with RDATEs.

CommentFileSizeAuthor
#2 date_ical-support_RDATE_time-2369109-2.patch2.33 KBcoredumperror

Comments

Renee S’s picture

Renee S commented
Category: Bug report » Feature request

Ok, well, found it, line 283 in date_ical_style_plugin_style_ical_feed. This isn't really a bug, as most people haven't hacked Date's additional fields to include a time (RTBC code to add that feature has been sitting in Date's queue for literally years), and it needs to get a time from somewhere... other use-case is people who have imported feeds and are re-exporting them for some reason, as those feeds might also have different times on their RDATEs. But that's pretty boutique.

So, updated from bug to feature request to set if time is set and use $start and $end if it isn't :)

coredumperror’s picture

coredumperror commented
StatusFileSize
new date_ical-support_RDATE_time-2369109-2.patch2.33 KB

Does this patch work? I don't know which patch you're referring to that makes Date support RDATE time, so I can't test it.

Renee S’s picture

Renee S commented

Oh, super, thank you! The original thread is here for adding times to Additional fields on Date (patch failed due to testbot issues only): https://www.drupal.org/node/1053158 ... Does a date object instantiated from an incomplete Date get a default time of 00:00:00? If it does, the patch wouldn't work; will do some testing!

coredumperror’s picture

coredumperror commented

How did your testing for this turn out? I'd like to close out this ticket, and either add this patch to Date iCal (if it worked), or throw it out.

Renee S’s picture

Renee S commented

It works, yes. Thank you!

Renee S’s picture

Renee S commented
Status: Active » Reviewed & tested by the community
coredumperror’s picture

coredumperror commented
Status: Reviewed & tested by the community » Fixed

I pushed this patch up to git, so it'll show up in the dev release shortly.

  • coredumperror committed 4c69149 on 7.x-3.x 
    Issue #2369109: Fixed a bug with the way RDATEs are generated in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.