FormBuilderTest uses wrapper for namespace to mock unused function

CommentFileSizeAuthor
#3 2367835-3.patch817 bytesrpayanm
fbt.patch805 bytesandypost

Comments

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks for the fix.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll 
git ac https://www.drupal.org/files/issues/fbt.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   805  100   805    0     0   2784      0 --:--:-- --:--:-- --:--:--  3026
error: patch failed: core/tests/Drupal/Tests/Core/Form/FormBuilderTest.php:5
error: core/tests/Drupal/Tests/Core/Form/FormBuilderTest.php: patch does not apply
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2367835-3.patch817 bytes
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

RTBC because it's a simple reroll :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Committed 6e09545 and pushed to 8.0.x. Thanks!

  • alexpott committed 6e09545 on 8.0.x 
    Issue #2367835 by rpayanm, andypost: Fixed FormBuilderTest namespace.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.