The .info file for version 6--1-2 should read 'version = 6.x-1.2'. Currently it shows up as 'unsupported' on the 'available updates' page (admin/reports/updates) when this is checked out of cvs as the version number is incorrect.

CommentFileSizeAuthor
#9 screengrab.jpg99.49 KBac
#8 pluralism_no_version.jpg27.87 KBjswaby
#5 dreamy_version_number_cvs.jpg25.54 KBjswaby
#4 dreamy_version_number.jpg24.91 KBjswaby
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jswaby’s picture

jswaby CreditAttribution: jswaby commented 
; $Id$
name = dreamy
description = A clean blog theme from the now defunct Ginger Ninja.
core = 6.x
version = VERSION
engine = phptemplate

I ripped this right from the D6 branch of the theme. What's missing?

jswaby’s picture

jswaby CreditAttribution: jswaby commented 
; $Id$
name = dreamy
description = A clean blog theme from the now defunct Ginger Ninja.
core = 6.x
version = VERSION
engine = phptemplate
; Information added by drupal.org packaging script on 2008-02-24
version = "6.x-1.2"
core = "6.x"
project = "dreamy"
datestamp = "1203839704"

Now this came right from the 1.2 release. Where's the problem?

ac’s picture

ac
Primary language English
Location Perth
CreditAttribution: ac commented

When I checked this out of CVS the line 'version = VERSION' was still as is. It needs to be 'version = 6.x-1.2'

jswaby’s picture

jswaby CreditAttribution: jswaby commented
FileSize
dreamy_version_number.jpg24.91 KB

If you're checking it out of CVS, you can't really say this is a bug. You are using a development version of the theme. Downloading the " Recommended for 6.x" status version of the theme gives you this: 6.x-1.2.

If you want the status updates, use the stable version "Recommended for 6.x", not the development version.

jswaby’s picture

jswaby CreditAttribution: jswaby commented
FileSize
dreamy_version_number_cvs.jpg25.54 KB

When you install it using CVS, you get "6.2-dev" or whatever version your drupal install is.

I've attached a screenshot indicating this.

If you want the status updates from the release system, use the stable version of the theme, not the dev version of the theme.

jswaby’s picture

jswaby CreditAttribution: jswaby commented
Status: Active » Postponed (maintainer needs more info)

Installing the TAG directly from CVS won't give you the version number.

From http://drupal.org/node/171205:

The version string will automatically be added by drupal.org when a release is created and a tarball packaged. So, you may omit this value for contributed themes. However, if your theme is not being hosted on the drupal.org infrastructure, you can give your theme whatever version string makes sense.

Did you want me to manually put in "6.x-1.2"? And then manually put in 6.x-1.3 for the next version, and so on?

ac’s picture

ac
Primary language English
Location Perth
CreditAttribution: ac commented

No I didn't want you to do that but when the stable version is checked out of CVS (cvs co -r DRUPAL-6-1--2 -dP), the version comes out as 'version = VERSION'. It may be because you are adding this to the .info file instead of letting the version string be automatically created.

jswaby’s picture

jswaby CreditAttribution: jswaby commented
FileSize
pluralism_no_version.jpg27.87 KB

That is actually not the case. Not putting 'version = VERSION' in the .info file leaves the version section blank on the themes page when checking it out of CVS. I did this exact same thing with my most recent, pluralism, simply because I forgot.

I've attached a screen shot of exactly what it looks like.

CVS does not automatically create the version number. drupal.org's release system creates these version numbers. Things that are created using CVS have the dollar signs ($) around it. For example, $Id$ would return the cvs information for the project.

From pluralism, "; $Id$" gives you:

; $Id: pluralism.info,v 1.1.2.1 2008/02/03 17:43:25 jswaby Exp $

The version string is automatically added by drupal.org when a release is created and a tarball is packaged.

ac’s picture

ac
Primary language English
Location Perth
CreditAttribution: ac commented
FileSize
screengrab.jpg99.49 KB

This is strange as I also have the latest stable release of pluralism checked out of the CVS. Like you say the pluralism.info file does not have a version string in it (even once checked out), yet it works as expected in the site (see attached image). The dreamy.info file contains 'version = VERSION' and in the site it is producing the error seen on the attached image.

If I manually remove the 'version = VERSION' from the dreamy.info file after checkout it displays the correct version number (6.x-1.2) on both the themes and update pages. It seems the solution is to leave that string out entirely from the dreamy.info file you check in and it will be added automatically for tarballs and is not needed for cvs.

jswaby’s picture

jswaby CreditAttribution: jswaby commented
Status: Postponed (maintainer needs more info) » Fixed

Alright. I'll take it out with the next commit.

I wouldn't have been able to find this. I only checkout branches for development, and download stable versions for use.

ac’s picture

ac
Primary language English
Location Perth
CreditAttribution: ac commented

Yeh it seems to be a common problem as its not an issue most devs would come across.
Cheers

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.